-
Notifications
You must be signed in to change notification settings - Fork 24
[PM-27231] Account registration v2 for key connector #611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[PM-27231] Account registration v2 for key connector #611
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
…ector # Conflicts: # crates/bitwarden-core/src/key_management/crypto_client.rs # crates/bitwarden-crypto/src/keys/mod.rs
🔍 SDK Breaking Change Detection ResultsSDK Version:
Breaking change detection completed. View SDK workflow |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #611 +/- ##
==========================================
+ Coverage 78.84% 78.99% +0.15%
==========================================
Files 283 284 +1
Lines 29660 30065 +405
==========================================
+ Hits 23384 23750 +366
- Misses 6276 6315 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
quexten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for your work on this. Some items that changed in the TDE request after responding to the feedback on it, and it seems like chacha rng was left over (from testing?) which would currently always generate the same key for all users.
…ector # Conflicts: # Cargo.lock
…ector # Conflicts: # Cargo.lock # crates/bitwarden-auth/Cargo.toml # crates/bitwarden-auth/src/registration.rs # crates/bitwarden-core/src/client/client.rs # crates/bitwarden-core/src/key_management/crypto_client.rs

🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-27231
📔 Objective
Account registration V2 for key connector.
Added
KeyConnectorKey, since we have to migrate fromMasterKeyfor key connector at some point.Added Key Connector API client crate, can set the key connector key for the user into the Key Connector server.
🚨 Breaking Changes
No changes to account registration V1.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes