Skip to content

Conversation

@quexten
Copy link
Contributor

@quexten quexten commented Dec 18, 2025

🎟️ Tracking

📔 Objective

Renames the non-standard "AsymmetricCryptoKey" to a more easily understandable "PrivateKey", "AsymmetricCryptoPublicKey" to "PublicKey". There is no functional changes.

This aligns with signature keys, and we should follow up with the same for symmetric keys:

- Secret Key Encryption:
  - SymmetricKey
- Public Key Encryption
  - PrivateKey
  - PublicKey
- Digital Signatures
  - SigningKey
  - VerifyingKey

🚨 Breaking Changes

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@quexten quexten changed the title Rename asymmetric key to private key Rename AsymmetricCryptoKey to PrivateKey Dec 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

Logo
Checkmarx One – Scan Summary & Details16c41b58-09eb-4f9a-88b7-2b9a9cb03403

Great job! No new security vulnerabilities introduced in this pull request

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

🔍 SDK Breaking Change Detection Results

SDK Version: km/rename-asymmetric-to-private (f2fdae9)
Completed: 2025-12-18 17:48:28 UTC
Total Time: 246s

Client Status Details
typescript ✅ No breaking changes detected TypeScript compilation passed with new SDK version - View Details

Breaking change detection completed. View SDK workflow

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 91.93548% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.52%. Comparing base (0a9599e) to head (f2fdae9).

Files with missing lines Patch % Lines
crates/bitwarden-crypto/src/store/context.rs 85.71% 7 Missing ⚠️
crates/bitwarden-core/src/auth/tde.rs 0.00% 1 Missing ⚠️
...bitwarden-crypto/src/keys/public_key_encryption.rs 88.88% 1 Missing ⚠️
crates/bitwarden-crypto/src/store/mod.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
- Coverage   78.54%   78.52%   -0.02%     
==========================================
  Files         283      283              
  Lines       29251    29218      -33     
==========================================
- Hits        22975    22944      -31     
+ Misses       6276     6274       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants