Fixes to configure after eth0 is up and start interfaces #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ec2ifup and ec2ifdown scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating for review only. We used your fork since it had the closest changes to what we needed, but found it was still missing udev events after eth0 is up.
Looking at the fedora port etuttle/ec2-utils we found it had a systemd and upstart script to re-send udev events after the network (eth0) was up by calling ec2ifscan.
We ported the upstart script and ec2ifscan to allow configuring devices after the intial on-boot udev hotplug events.
The fedora port also had additional udev rules to perform an ifup (through systemd service) and ifdown (calling directly). Since we're using upstart, we didn't have the same capabilities as the systemd service so we call ifup directly in the udev rules.
This seems to work when ENIs are attached at boot time, resulting in configured interfaces that are brought up. We have not yet tested dynamic hotplugging, which I suspect won't work due to not having the same capabilities as the fedora systemd service used in the fedora port.
Is this PR something that would be useful to you to merge? It seems like it gains some incremental functionality towards what Amazon Linux and the fedora port have. If you have any comments on what could be changed, I'm very happy to update the PR. Thanks!