Skip to content
This repository was archived by the owner on Jan 14, 2020. It is now read-only.

Conversation

@Tanooj0902
Copy link
Contributor

No description provided.

@Tanooj0902 Tanooj0902 changed the title [BA-794] Up-loadable app [BA-794] App Bundle Mar 13, 2018
@Tanooj0902 Tanooj0902 changed the title [BA-794] App Bundle [BA-794][WIP] App Bundle Mar 13, 2018
@Tanooj0902 Tanooj0902 force-pushed the BA-794 branch 2 times, most recently from 201f91e to 3f7605e Compare March 15, 2018 05:54
@Tanooj0902 Tanooj0902 changed the title [BA-794][WIP] App Bundle [BA-794] App Bundle Mar 28, 2018
@mernit mernit requested a review from th0114nd March 28, 2018 13:51
@th0114nd
Copy link
Contributor

Hi Tanooj, #88 is a version of the dapp bundle that I was able to get working. There were some issues in the bundle, and some in apex.
In the bundle:

  1. import paths mismatching file locations
  2. bytes32 arguments must be 32 bytes hex encoded for the _pwHash
  3. Enums should be encoded as integers, rather than strings. So 2 works but "ADMIN" does not.

In apex:

  1. Errors were not even making it into the logs, let alone the return values. This made it very hard to discover the above problems
  2. Simultaneous contract uploads led to nonce collisions.
  3. Apex was not resolving imports before checking that compilation worked.
  4. Apex used fs.readdir to find relevant contracts, and if there were nested directories it tried to parse those as solidity files and failed.

To reiterate apex.1, all 6 of the other errors looked identical. blockapps/blockapps-rest#62 helps with some of the error reporting, and https://github.com/blockapps/apex/pull/21 solves the rest and most of the apex issues, as long as the file hierarchy is flat.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants