v1.4.0 #1505
v1.4.0 #1505
Conversation
…hQL query structure
…ic token decimals
fix: issue with hover on sidebar buttons
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| /> | ||
| <div className="flex items-center opacity-0 transition-opacity [tr:hover_&]:opacity-100"> | ||
| <CopyAndPasteButton | ||
| textToCopy={address as `0x${string}`} |
There was a problem hiding this comment.
Copy button copies wrong address in table rows
The CopyAndPasteButton component uses the address prop (which is the parent component's address parameter) instead of addressValue (the row's actual address from row.getValue("address")). This causes users to copy the wrong address - they'll always copy the main account address rather than the address displayed in each table row.
Additional Locations (2)
|
|
||
| setIsFilterActive( | ||
| !!(filterVariables?.minDelta || filterVariables?.maxDelta), | ||
| ); |
There was a problem hiding this comment.
Filter active state uses stale values
The setIsFilterActive call checks filterVariables state values that were just updated with setFilterVariables. Since React state updates are asynchronous, filterVariables still contains the previous values at this point. The check references the old filter state instead of the new values being applied (from filterState.minAmount/filterState.maxAmount), causing isFilterActive to be out of sync with the actual filter state.
Additional Locations (2)
| }); | ||
| }); | ||
|
|
||
| if (othersValue > BigInt(0)) { |
There was a problem hiding this comment.
Comparing number to BigInt is inconsistent
The variable othersValue is a regular JavaScript number (calculated from subtraction of two numbers on line 155), but it's being compared to BigInt(0). While JavaScript allows mixed comparisons, this is inconsistent with the data types in use and could lead to unexpected behavior. The comparison othersValue > 0 would be more appropriate here.
| label: displayLabel, | ||
| value: | ||
| token === "ERC20" | ||
| ? Number(BigInt(delegator.rawBalance) / BigInt(10 ** 18)) |
There was a problem hiding this comment.
Hardcoded decimals inconsistent with dynamic decimals usage
The pie chart data for individual delegators uses a hardcoded 10 ** 18 divisor, but the "Others" slice on line 157 correctly uses the decimals variable from the DAO config. This inconsistency means the delegator values in the pie chart will be incorrectly calculated for tokens with non-18 decimals, while the "Others" value will be correct, causing the chart to display mismatched proportions.
Note
Introduces richer analytics and URL-driven state across Holders & Delegates, plus Storybook theming and API filter enhancements.
useBalanceHistory,useBalanceHistoryGraph,useDelegateDelegationHistory(from/to filters),useDelegationHistory,useAccountInteractionsData; minor API changes inuseDelegates/useTokenHoldersvotingPowersquery withfromAddresses/toAddressesWritten by Cursor Bugbot for commit bb8e702. This will update automatically on new commits. Configure here.