Skip to content

Refactor use state hash for sync rebased #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
HristoStaykov wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Refactor use state hash for sync rebased #1608

HristoStaykov wants to merge 3 commits into from

Conversation

@HristoStaykov
Copy link
Contributor

@HristoStaykov HristoStaykov commented Aug 28, 2025 •
edited
Loading

Initial version of using Merkle root over all call-data updates generated per network.

@HristoStaykov HristoStaykov force-pushed the refactor_use_state_hash_for_sync_rebased branch 2 times, most recently from a70d70c to 7b98862 Compare September 23, 2025 11:43
@HristoStaykov HristoStaykov force-pushed the refactor_use_state_hash_for_sync_rebased branch from 7b98862 to aab4435 Compare September 23, 2025 12:10
@HristoStaykov HristoStaykov force-pushed the refactor_use_state_hash_for_sync_rebased branch from aab4435 to b9822d0 Compare October 10, 2025 10:22
@HristoStaykov HristoStaykov force-pushed the refactor_use_state_hash_for_sync_rebased branch from b9822d0 to 123cd2c Compare October 13, 2025 11:34
@HristoStaykov HristoStaykov force-pushed the refactor_use_state_hash_for_sync_rebased branch from 123cd2c to 84d11f5 Compare October 13, 2025 12:31
@HristoStaykov HristoStaykov force-pushed the refactor_use_state_hash_for_sync_rebased branch from 84d11f5 to 5c44561 Compare October 13, 2025 13:02
@HristoStaykov HristoStaykov force-pushed the refactor_use_state_hash_for_sync_rebased branch from 5c44561 to 18a25cc Compare October 22, 2025 09:18
HristoStaykov
HristoStaykov commented Oct 29, 2025
View reviewed changes
apps/sequencer/src/providers/eth_send_utils.rs

provider.update_history(&updates.updates);
let result = receipt.status().to_string();
if result == "true" {
Copy link
Contributor Author

@HristoStaykov HristoStaykov Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Make an enum that contains the tx results from alloy and adds a timeout status.

@HristoStaykov HristoStaykov force-pushed the refactor_use_state_hash_for_sync_rebased branch from 18a25cc to eac011d Compare October 30, 2025 10:28
Base automatically changed from remove_multicall to main October 30, 2025 14:34
@HristoStaykov HristoStaykov force-pushed the refactor_use_state_hash_for_sync_rebased branch from eac011d to 5215d2f Compare October 30, 2025 15:29
@HristoStaykov HristoStaykov changed the base branch from main to refactor_feed_id_stride October 30, 2025 16:00
@HristoStaykov HristoStaykov force-pushed the refactor_feed_id_stride branch from 35af4b0 to f17b0e3 Compare October 30, 2025 16:16
@HristoStaykov HristoStaykov force-pushed the refactor_use_state_hash_for_sync_rebased branch from 5215d2f to 571691f Compare October 30, 2025 16:16
@reo101 reo101 force-pushed the refactor_use_state_hash_for_sync_rebased branch from 571691f to 7f663bd Compare October 30, 2025 16:31
@reo101 reo101 force-pushed the refactor_feed_id_stride branch 2 times, most recently from 46800c5 to 15e4ab0 Compare October 30, 2025 16:34
@reo101 reo101 force-pushed the refactor_use_state_hash_for_sync_rebased branch from 7f663bd to 3865f85 Compare October 30, 2025 16:34
@reo101 reo101 force-pushed the refactor_feed_id_stride branch from 15e4ab0 to 9a0349f Compare October 30, 2025 16:49
@reo101 reo101 force-pushed the refactor_use_state_hash_for_sync_rebased branch from 3865f85 to 16eebd2 Compare October 30, 2025 16:49
@reo101 reo101 force-pushed the refactor_use_state_hash_for_sync_rebased branch from 16eebd2 to e906ed3 Compare November 7, 2025 12:45
@reo101 reo101 force-pushed the refactor_feed_id_stride branch from 9a0349f to 0290a90 Compare November 7, 2025 12:50
@reo101 reo101 force-pushed the refactor_use_state_hash_for_sync_rebased branch 4 times, most recently from d96ad89 to 93fa6c3 Compare November 7, 2025 14:00
@reo101 reo101 force-pushed the refactor_feed_id_stride branch from 2ed487d to 258e829 Compare November 7, 2025 14:00
@reo101 reo101 force-pushed the refactor_use_state_hash_for_sync_rebased branch from 93fa6c3 to 8f4ecd1 Compare November 7, 2025 14:08
@HristoStaykov HristoStaykov force-pushed the refactor_feed_id_stride branch from c74b4f8 to a942cab Compare November 7, 2025 14:15
@reo101 reo101 force-pushed the refactor_use_state_hash_for_sync_rebased branch from 8f4ecd1 to 4fe7564 Compare November 7, 2025 14:16
@HristoStaykov HristoStaykov force-pushed the refactor_feed_id_stride branch from a942cab to 9ff7fd7 Compare November 7, 2025 14:23
@reo101 reo101 force-pushed the refactor_feed_id_stride branch from 9ff7fd7 to a942cab Compare November 7, 2025 14:24
Base automatically changed from refactor_feed_id_stride to main November 7, 2025 14:34
@reo101 reo101 force-pushed the refactor_use_state_hash_for_sync_rebased branch 2 times, most recently from 140b9f8 to eb670b4 Compare November 7, 2025 15:12
@HristoStaykov @Owliie @reo101
fix(sequencer/tests): Take into consideration changes to serializatio…
caee75b 
…n regarding source/target hashes

Co-authored-by: Aneta Tsvetkova <anetastsvetkova@gmail.com>
@reo101 reo101 force-pushed the refactor_use_state_hash_for_sync_rebased branch from eb670b4 to caee75b Compare November 7, 2025 15:32
HristoStaykov
HristoStaykov commented Nov 7, 2025
View reviewed changes
apps/sequencer/src/providers/eth_send_utils.rs
provider.calldata_merkle_tree_frontier = next_calldata_merkle_tree;
provider.merkle_root_in_contract = None;
debug!("Successfully updated contract in network `{net}` block height {block_height} Merkle root {root:?}");
} // TODO: Reread round counters + latest state hash from contract
Copy link
Contributor Author

@HristoStaykov HristoStaykov Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment not relevant to this code path. TODO: Remove.

HristoStaykov
HristoStaykov commented Nov 7, 2025
View reviewed changes
apps/sequencer/src/providers/provider.rs

impl Hashable for HashValue {
fn combine(_level: Level, a: &Self, b: &Self) -> Self {
HashValue(keccak256([a.0.to_vec(), b.0.to_vec()].concat()))
Copy link
Contributor Author

@HristoStaykov HristoStaykov Nov 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reo101: TODO: refactor to not make heap allocations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PetarKirov PetarKirov Awaiting requested review from PetarKirov

@Owliie Owliie Awaiting requested review from Owliie

@EmilIvanichkovv EmilIvanichkovv Awaiting requested review from EmilIvanichkovv

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HristoStaykov @Owliie