Update Yaci Store version, fix yaci-store jar download handling, rollback enhancements #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgraded Yaci Store to version 2.0.0-beta3 across CLI configs and Earthfile. Improved download process to handle jar packaged in a zip file, adding extraction, file relocation, and cleanup steps. Adjusted error handling to handle null ClusterInfo and refined logic for jar-specific downloads.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades Yaci Store to version 2.0.0-beta3 and adapts the download process to handle a new distribution format where the jar file is packaged within a zip file. The changes improve error handling for cluster operations and refine the download logic.
Key changes:
- Updated Yaci Store version from 2.0.0-beta2 to 2.0.0-beta3 across configuration files
- Modified jar download process to extract from zip file, including file extraction, relocation, and cleanup
- Enhanced error handling in LocalPeerService to handle null ClusterInfo cases
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| applications/cli/config/download.properties | Updated Yaci Store version numbers to 2.0.0-beta3 |
| applications/cli/Earthfile | Updated STORE_NATIVE_BRANCH to release/2.0.0-beta3 |
| applications/cli/src/main/java/com/bloxbean/cardano/yacicli/commands/general/DownloadCommand.java | Removed yaci-store-jar from "all" component download logic |
| applications/cli/src/main/java/com/bloxbean/cardano/yacicli/commands/common/DownloadService.java | Added zip extraction logic for yaci-store jar download and updated download URL |
| applications/cli/src/main/java/com/bloxbean/cardano/yacicli/localcluster/peer/LocalPeerService.java | Enhanced error handling to catch all exceptions and handle null ClusterInfo |
...ications/cli/src/main/java/com/bloxbean/cardano/yacicli/commands/common/DownloadService.java
Outdated
Show resolved
Hide resolved
...ications/cli/src/main/java/com/bloxbean/cardano/yacicli/commands/common/DownloadService.java
Outdated
Show resolved
Hide resolved
| clusterInfo = clusterInfoService.getClusterInfo(clusterName); | ||
| } catch (IOException e) { | ||
| writeLn(error("Unable to get cluster info for " + clusterName + ": " + e.getMessage())); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
The original error message was removed when changing from IOException to Exception. This makes debugging harder as errors are now silently ignored. Consider logging the exception or providing some indication of what went wrong.
Suggested change
| } catch (Exception e) { | |
| } catch (Exception e) { | |
| log.error("Error retrieving cluster info for cluster: " + clusterName, e); |
...ications/cli/src/main/java/com/bloxbean/cardano/yacicli/commands/common/DownloadService.java
Outdated
Show resolved
Hide resolved
Enabled `adapot` and `governance-aggr` features in application properties. Added `PUBLIC_INDEXER_CLIENT_BASE_URL` for client-side usage to improve environmental variable flexibility. Updated `NetworkInfo.svelte` to prioritize the client-specific base URL.
Introduced support for configuring a stake ratio factor in multi-node cluster setups, improving flexibility in testing rollback scenarios. Adjusted stake amount allocation logic, updated CLI options, and ensured proper handling in related services.
Introduce a new `/devnet/tip` API to fetch the current tips for all nodes, supporting multi-node setups. The response includes block number, slot, and hash for each node and indicates if multi-node mode is enabled. This enhances visibility into the cluster's state.
…mmands/common/DownloadService.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…mmands/common/DownloadService.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…mmands/common/DownloadService.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
satran004
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI Updates:
20.04to22.04in.github/workflows/dev-release-cli.yml,.github/workflows/release-cli.yml, and.github/workflows/release-viewer.ymlto ensure compatibility with newer environments. [1] [2] [3] [4]Yaci Store Updates:
2.0.0-beta2to2.0.0-beta3inapplications/cli/Earthfileandapplications/cli/config/download.properties. [1] [2]DownloadServiceto handle downloading and extracting the Yaci Store jar from a zip file instead of directly downloading the jar file. [1] [2]Store Feature Enhancements:
store.adapot.enabled,store.governance-aggr.enabled, and their corresponding APIs inapplications/cli/docker/store-application.properties.Multi-Node Cluster Support:
ClusterCommands,ClusterInfo,ClusterService,ClusterStartService, andClusterAdminController. [1] [2] [3] [4] [5]Code Enhancements:
StandardCopyOptionimport and refactoring download logic inDownloadService. [1] [2]ClusterStartService. [1] [2]