Skip to content

Conversation

@Flamefire
Copy link
Contributor

No description provided.

@Flamefire Flamefire force-pushed the ci branch 3 times, most recently from 68bf8d2 to 2e251c8 Compare December 6, 2024 16:25
@jefftrull
Copy link
Collaborator

Can you briefly explain these changes? I know we were wrestling with node versions and support for old compilers last year. This PR reverts one of my workarounds/hacks for that issue. How does this one deal with the problem? Thanks.

@Flamefire
Copy link
Contributor Author

Sure. This was part of a bulk change over almost 40 repos, hence I've been very brief on description. In short:

macos-12 runners are dropped by github and jobs won't start anymore. at least macos-13 needs to be used

Containers need to be run on the latest ubuntu runner to avoid trouble, e.g. github removing the host runner os or IIRC some stuff wasn't supported on older OS.

Support for node 16 was fully dropped by GitHub --> @V3 actions don't work anymore and $ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION has no effect. So I removed the variable and updated to @v4 actions which require node 20. Github bind-mounts a node20 installation into the container which is incompatible with the glibc of ubuntu 16/18 and due to that mount an installation in the docker image won't work.

This solution downloads an unofficial node 20 built against the correct/older glibc and creates 2 mount points such that we can put that node onto the host runner and mount that instead of what github gives us using the idea from https://github.com/dixyes/ghactionsplay/blob/bf889ee2fed8dcd72cc8e32bfd4789be177c958f/.github/workflows/glibc217node20.yml
To avoid overloading the unofficial-builds.nodejs.org server we use a copy hosted at boost.io

Does that answer your questions or do you need more details?

@jefftrull jefftrull merged commit 2891b2f into boostorg:develop Dec 9, 2024
7 checks passed
@jefftrull
Copy link
Collaborator

This fix supersedes the previous hack in #217 thanks @Flamefire

@Flamefire Flamefire deleted the ci branch December 10, 2024 08:58
@jefftrull
Copy link
Collaborator

Finally getting around to merging into master and I wondered if you had any insights on the CI failure. Clang, so doesn't seem related to this PR but thought I would ask https://github.com/boostorg/wave/actions/runs/14656737135

@Flamefire
Copy link
Contributor Author

See the message at the bottom of the run:

This is a scheduled Ubuntu 20.04 retirement. Ubuntu 20.04 LTS runner will be removed on 2025-04-15.

So the failure is "intended".

I opened #239 for an update.

@jefftrull
Copy link
Collaborator

Thanks again for your many contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants