Skip to content

Implement support for digit separators in preprocessor expressions #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jefftrull merged 1 commit into from
Nov 17, 2025
Merged

Implement support for digit separators in preprocessor expressions #244

jefftrull merged 1 commit into from
Nov 17, 2025

Conversation

@jefftrull
Copy link
Collaborator

@jefftrull jefftrull commented Nov 13, 2025 •
edited
Loading

Integers with digit separators are already recognized as literal tokens. This commit adds proper interpretation of them as integers for use in expressions, e.g. with #if, by:

  1. Adding digit separators to the RE2C code that handles pp-numbers,
  2. Filtering out digit separators before extracting numeric values, and
  3. Adding appropriate unit tests

@jefftrull
Implement support for digit separators in preprocessor expressions
144df5f 
Integers with digit separators are already recognized as literal
tokens. This commit adds proper interpretation of them as integers for
use in expressions e.g. with #if
@jefftrull jefftrull requested a review from hkaiser November 13, 2025 22:36
@jefftrull
Copy link
Collaborator Author

jefftrull commented Nov 13, 2025

FYI @APokorny

@jefftrull jefftrull merged commit ac31d13 into boostorg:develop Nov 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hkaiser hkaiser Awaiting requested review from hkaiser

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jefftrull