Allow env var override for running ztests in vector runtime #6447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwt
reviewed
Dec 16, 2025
Member
nwt
left a comment
nwt
left a comment
There was a problem hiding this comment.
I think we should do this in the sqllogic-ztests repository rather than here. I'll explain how when I'm back in front of a keyboard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
This adds support for env var
ZTEST_VECTORwhich can be set totrueto have the same effect as having addedvector: trueto each ztest YAML.Why
I want to sometimes run the sqllogic-ztests in vector runtime, but since there's still lots more failures there than in sequential, I'd like to keep the "golden" set of ztest YAML set for just the default of running sequential, but have an easy way to override that. The only way I saw to do this before was to keep a separate copy of all the ztest YAML files edited to include
vector: true, which is cumbersome.Details
I'm not much of a Go developer, so I had Claude AI create this diff. It's functionally giving me what I need (e.g., this Actions run) but I respect AI's code may have its shortcomings, so if someone's game to rewrite it better or I have to just live off my branch, I'm ok with that.