Clean workspace dev dependencies #1340
Conversation
|
Greptile OverviewGreptile SummaryCleaned up root workspace
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Root as Root Workspace
participant Core as packages/core
participant Evals as packages/evals
Note over Root: Before: 26 devDependencies
Root->>Core: Move @types/adm-zip, @types/node, adm-zip, chalk, esbuild
Root->>Evals: Move braintrust, string-comparison
Note over Root: Remove 19 unused deps<br/>(langchain, cheerio, express, etc.)
Note over Root: After: 9 devDependencies
Note over Core: +5 devDependencies
Note over Evals: +2 devDependencies
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 issues found across 4 files
Prompt for AI agents (all 3 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/evals/package.json">
<violation number="1" location="packages/evals/package.json:24">
P1: `braintrust` is required at runtime (imported by the eval runner and AISDK wrapper) but was added as a devDependency, so consumers will miss it and the CLI will fail to start.</violation>
<violation number="2" location="packages/evals/package.json:25">
P1: `chalk` is used by the runtime CLI but was added under devDependencies, so running the CLI outside the workspace will fail due to the missing module.</violation>
<violation number="3" location="packages/evals/package.json:26">
P1: `string-comparison` powers runtime scoring utilities but is declared as a devDependency, so downstream installs will miss it and runtime imports will throw.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
| "devDependencies": { | ||
| "braintrust": "^0.4.7", | ||
| "chalk": "^5.4.1", | ||
| "string-comparison": "^1.3.0", |
There was a problem hiding this comment.
P1: string-comparison powers runtime scoring utilities but is declared as a devDependency, so downstream installs will miss it and runtime imports will throw.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/evals/package.json, line 26:
<comment>`string-comparison` powers runtime scoring utilities but is declared as a devDependency, so downstream installs will miss it and runtime imports will throw.</comment>
<file context>
@@ -21,6 +21,9 @@
"devDependencies": {
+ "braintrust": "^0.4.7",
+ "chalk": "^5.4.1",
+ "string-comparison": "^1.3.0",
"tsx": "^4.10.5"
}
</file context>
| }, | ||
| "devDependencies": { | ||
| "braintrust": "^0.4.7", | ||
| "chalk": "^5.4.1", |
There was a problem hiding this comment.
P1: chalk is used by the runtime CLI but was added under devDependencies, so running the CLI outside the workspace will fail due to the missing module.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/evals/package.json, line 25:
<comment>`chalk` is used by the runtime CLI but was added under devDependencies, so running the CLI outside the workspace will fail due to the missing module.</comment>
<file context>
@@ -21,6 +21,9 @@
},
"devDependencies": {
+ "braintrust": "^0.4.7",
+ "chalk": "^5.4.1",
+ "string-comparison": "^1.3.0",
"tsx": "^4.10.5"
</file context>
| "zod": "^4.1.8" | ||
| }, | ||
| "devDependencies": { | ||
| "braintrust": "^0.4.7", |
There was a problem hiding this comment.
P1: braintrust is required at runtime (imported by the eval runner and AISDK wrapper) but was added as a devDependency, so consumers will miss it and the CLI will fail to start.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/evals/package.json, line 24:
<comment>`braintrust` is required at runtime (imported by the eval runner and AISDK wrapper) but was added as a devDependency, so consumers will miss it and the CLI will fail to start.</comment>
<file context>
@@ -21,6 +21,9 @@
"zod": "^4.1.8"
},
"devDependencies": {
+ "braintrust": "^0.4.7",
+ "chalk": "^5.4.1",
+ "string-comparison": "^1.3.0",
</file context>
There was a problem hiding this comment.
this package is not published so install will still hit dev
There was a problem hiding this comment.
Thanks for the feedback! I've saved this as a new learning to improve future reviews.
miguelg719
changed the base branch from
main
to
miguelgonzalez/stg-992-update-suggested-models-in-docs
miguelg719
changed the base branch from
miguelgonzalez/stg-992-update-suggested-models-in-docs
to
main
miguelg719
force-pushed
the
miguelgonzalez/stg-1031-clean-workspace-devdependencies
branch
from
78b9fc0 to
e3b0277
Compare
PR Review: Clean workspace dev dependenciesSummaryThis PR successfully moves development dependencies from the workspace root to their respective packages (packages/core and packages/evals) and removes unused dependencies. This is a positive change that improves the monorepo structure and reduces installation bloat. ✅ Code Quality & Best PracticesExcellent work on:
✅ Verification of ChangesI verified that all moved dependencies are actually used in their target packages: packages/core/package.json - Added dependencies are used:
packages/evals/package.json - Added dependencies are used:
✅ Build ScriptsVerified that build tools remain accessible:
✅ Removed DependenciesThe following dependencies were removed from the root and appear to be truly unused:
✅ Security & Performance
🎯 Potential Considerations
📋 Test CoverageThe PR description mentions "test plan" but it is empty. Consider adding:
✅ Final VerdictLGTM! 🚀 This is a well-executed cleanup that improves the project structure. The changes are:
Recommendation: Approve and merge after CI passes. Review generated by Claude Code |
why
These dev dependencies don't belong here. Some are no longer used, some should go into their respective packages
what changed
Moved dev dependencies to respective packages and removed unused ones
test plan
Summary by cubic
Moved dev dependencies from the workspace root into the packages that use them and removed unused ones to cut install bloat.
Written for commit e3b0277. Summary will update automatically on new commits.