generate precise traps in component adapters #12215
Merged
+294
−2,097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we generated a generic `unreachable` instruction for each trap in a fused adapter, plus some metadata to recover the specific kind of trap. However, that metadata was never hooked up to anything, so we only got a generic `unreachable` message at runtime. This commit removes the metadata tracking and instead simply calls a host intrinsic, passing the trap code as a parameter. This is somewhate pessimal compared with what we had before, but improves ergonomics and allows us to avoid forking as many tests from the component-model repo. If performance becomes an issue, we can easily add an option to skip the host call and only emit an `unreachable` instruction as before. Note that I've removed forked versions of three tests in favor of their upstream equivalents. Fixes bytecodealliance#11683
alexcrichton
approved these changes
Dec 23, 2025
github-actions
bot
added
the
wasmtime:api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we generated a generic
unreachableinstruction for each trap in a fused adapter, plus some metadata to recover the specific kind of trap. However, that metadata was never hooked up to anything, so we only got a genericunreachablemessage at runtime.This commit removes the metadata tracking and instead simply calls a host intrinsic, passing the trap code as a parameter. This is somewhate pessimal compared with what we had before, but improves ergonomics and allows us to avoid forking as many tests from the component-model repo.
If performance becomes an issue, we can easily add an option to skip the host call and only emit an
unreachableinstruction as before.Note that I've removed forked versions of three tests in favor of their upstream equivalents.
Fixes #11683