chore: simplify construction of MemoryPoolAllocator with user supplied buffer by creating new BaseAllocator internally on default #122
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uffer by creating new BaseAllocator internally on default
X-czh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Creating a new
BaseAllocatorinternally if not supplied for the constructor ofMemoryPoolAllocatorwith user supplied buffer.Why are the changes needed?
Currently, user has to supply a constructor for
BaseAllocator(default to 0) when calling the constructor ofMemoryPoolAllocatorwith user supplied buffer. As a result, the default parameter of chunk size does not take effect as well, as one has to supply supply a constructor forBaseAllocatoranyway.We can improve user experience by creating a new
BaseAllocatorinternally if not supplied, the same approach adopted by the constructor without user supplied buffer.