Fixing OOM created by the admission hook #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of CS477: Advanced Operating Systems at EPFL, we (@AgeX21, @TizianKurz, and me) reproduced and extended linux-cache-ext as part of a class project. As part of this work, we implemented a custom admission policy based on TinyLFU.
We discovered a critical OOM bug. Specifically, when a page is not admitted into the cache, a temporary page is allocated but never freed correctly. As a result, the memory is filled in a matter of seconds in a memory intensive application.
This pull request fixes the issue by:
In our tests, these changes eliminate the memory leak. We are happy to provide additional details if needed.