Feature/gmcp ansi #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emit error upon error. There was as parse error, and the program would simply halt. With this fix an error will propagate to 'error' listeners. Still seems to halt, but at least one can know why.
Add support for ANSI in GMCP messages. Some servers - looking at you aardwolf - will include the ESC char directly in the JSON. This makes the JSON invalid. This fix replaces the ESC sequence with escaped string char. ANSI should come out correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for ANSI in GMCP messages.
Some servers - looking at you aardwolf - will include the ESC char directly in the JSON.
This makes the JSON invalid. This fix replaces the ESC sequence with escaped string char.
ANSI should come out correct.