secboot: use device node to find the storage container and keys #16370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Run only one system
|
Mon Dec 15 18:24:35 UTC 2025 Failures:Preparing:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #16370 +/- ##
==========================================
+ Coverage 77.48% 77.49% +0.01%
==========================================
Files 1340 1337 -3
Lines 183046 183012 -34
Branches 2438 2438
==========================================
- Hits 141838 141833 -5
+ Misses 32613 32583 -30
- Partials 8595 8596 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alfonsosanchezbeato
added
Run nested
Member
Author
|
Spread tests are fine with this change. |
valentindavid
approved these changes
Dec 15, 2025
We do not want to use a symlink as we do not want to rely on udev having created them at this point in the boot process. Use directly the device node that we already now. We still need to use paths for the symlinks when calling WithLegacyKeyringKeyDescriptionPaths for the descriptions in the kernel keyring, but they are not accessed because of this.
alfonsosanchezbeato
force-pushed
the
use-dev-node-secboot
branch
from
3e08b2b to
5b3ac1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not want to use a symlink as we do not want to rely on udev having created them at this point in the boot process. Use directly the device node that we already now. We still need to use paths for the symlinks when calling WithLegacyKeyringKeyDescriptionPaths for the descriptions in the kernel keyring, but they are not accessed because of this.