data/selinux/snappy: allow connecting to squid proxy #16375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already allow connecting to generic HTTP proxies (classified as http_cache_port_t). Extend the policy to allow connecting to squid proxies (squid_port_t), in case someone is using them (like we do in tests running in PS7). Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the SELinux policy for snapd to allow connecting to squid proxy servers in addition to the already supported generic HTTP proxies. This change is needed for test environments using squid proxies.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #16375 +/- ##
==========================================
- Coverage 77.55% 77.49% -0.07%
==========================================
Files 1329 1340 +11
Lines 182828 183046 +218
Branches 2438 2438
==========================================
+ Hits 141791 141843 +52
- Misses 32455 32611 +156
- Partials 8582 8592 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Tue Dec 16 20:39:04 UTC 2025 Failures:Preparing:
Executing:
Restoring:
|
bboozzoo
added
Auto rerun spread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already allow connecting to generic HTTP proxies (classified as http_cache_port_t). Extend the policy to allow connecting to squid proxies (squid_port_t), in case someone is using them (like we do in tests running in PS7).
Thanks for helping us make a better snapd!
Have you signed the license agreement and read the contribution guide?