Skip to content

Conversation

@froggleston
Copy link
Member

This PR tries to address some of the lacking detail in the python install instructions, ref #871 and #866

@netlify
Copy link

netlify bot commented May 15, 2025

Deploy Preview for workshop-template-previews ready!

Name Link
🔨 Latest commit e22060b
🔍 Latest deploy log https://app.netlify.com/projects/workshop-template-previews/deploys/6852a93699342500083c9146
😎 Deploy Preview https://deploy-preview-872--workshop-template-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@ErinBecker ErinBecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look like great improvements and do address #866 and #871, however, the formatting is a bit off. I'm assuming each substep of the "EITHER" option should be formatted as a separate bullet point instead of a single text block (like the "OR" option is). If that's not the intention, please ignore this suggestion and go ahead and merge.

Screenshot 2025-05-22 at 1 33 58 PM

@jas58
Copy link
Contributor

jas58 commented May 27, 2025

I'm not sure where to add this change
conda env create -f .\Users\jastubbs\Downloads\carpentries_environment.yml

I needed, as a Windows user, to insert --after the .\ and before the \Downloads-- the User directory and the username
But another learner could not locate or install the enviro file from the browser/Onedrive controlled download folder to wherever miniforge wanted to see it. So the admin IT had them create and edit the enviro text via nano but no luck because no permission to write there.

@froggleston
Copy link
Member Author

I'm afraid I can't reproduce this here.

I also have a OneDrive (Personal) home folder on my Windows laptop, and followed the instructions, and everything was in the right place:
image

I would recommend using the git bash mechanism if using OneDrive as it would be explicit where the curl download is happening, rather than the right click "Save As..." which might end up being confusing with actual file paths due to Windows File Explorer.

@froggleston
Copy link
Member Author

froggleston commented Jun 6, 2025

Hmm, maybe something like conda env create -f .\%USERPROFILE%\Downloads\carpentries_environment.yml would be better as it would definitely avoid any differences?

And thanks @ErinBecker - I've made those adjustments to the bullet list.

@froggleston froggleston self-assigned this Jun 6, 2025
@jas58
Copy link
Contributor

jas58 commented Jun 8, 2025 via email

@jas58
Copy link
Contributor

jas58 commented Jun 8, 2025 via email

@froggleston
Copy link
Member Author

froggleston commented Jun 9, 2025

Where you mention "curl", I assume you mean URL, but I would like to
discuss this idea further. Do you mean after the browser download, using
the browser GUI interface to open that folder location of the new file,
then in File Explorer right click for the context menu to "Open in Git
Bash"? If so, yes, I think this has been much more reliable.

No, I am referring to curl as the command line tool to download the environment file, but your point about this assuming learners have already had shell experience is a very good one.

Sadly, the "Open in Git Bash" route is also not without hurdles, as different systems may not list Git for Windows in the accepted list of programs with which to open the file. So users in this case would have to go manually searching around their Program Files folder. Also, if you do try to open the file using the right-click "Open with ..." mechanism and selecting Git for Windows (git bash), it will simply fail to run properly.

I think the only option we have is to provide some extra information for those that might have problems with accessing C:\Users\<username>\Downloads ....

@jas58
Copy link
Contributor

jas58 commented Jun 9, 2025 via email

@froggleston
Copy link
Member Author

OK, I'll try to rework the text this week and add some instructor notes to review. Thanks for the really useful feedback!

@froggleston froggleston requested a review from tobyhodges June 10, 2025 16:34
@froggleston
Copy link
Member Author

froggleston commented Jun 10, 2025

@tobyhodges Ready for review!

NB: I've also updated the R instructions as they were not detailed, or specific for WSL. I note that the DC install instructions for R are still using the ecology-workshop notes - these materials use old instructions for rstudio.org rather than the newer POSIT ones.

Copy link
Member

@tobyhodges tobyhodges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @froggleston, barring some minor polishes I have suggested. I would love to get a review from somebody with more Windows experience before merging, if possible.

froggleston and others added 4 commits June 18, 2025 12:55
Co-authored-by: Toby Hodges <tbyhdgs@gmail.com>
Co-authored-by: Toby Hodges <tbyhdgs@gmail.com>
Co-authored-by: Toby Hodges <tbyhdgs@gmail.com>
Co-authored-by: Toby Hodges <tbyhdgs@gmail.com>
@tobyhodges tobyhodges merged commit 7b0b6e6 into carpentries:gh-pages Jun 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants