1325: extend define xml readers _get_metadata_representation #1483
+70
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…taset_has_no_data
RamilCDISC
requested changes
Dec 15, 2025
…taset_has_no_data
gerrycampion
approved these changes
Jan 2, 2026
…taset_has_no_data
RamilCDISC
approved these changes
Jan 4, 2026
Collaborator
RamilCDISC
left a comment
RamilCDISC
left a comment
There was a problem hiding this comment.
The PR adds extends define xml for has_no_data. The PR was validated by:
- Reviewing the PR for any unwanted changes or comments.
- Reviewing the PR logic in accordance with the AC.
- Reviewing the updated tests.
- Ensuring updated tests cover the cases required for the updated logic.
- Ensuring all unit and regression testing pass.
- Running manual testing using positive dataset.
- Running manual testing using negative dataset.
RamilCDISC
deleted the
1325-extend-define-xml-reader-with-define_dataset_has_no_data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.