-
Notifications
You must be signed in to change notification settings - Fork 27
#1274: Add inline compared syntax for N-way set-based output variable comparison
#1491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RakeshBobba03
wants to merge
6
commits into
main
Choose a base branch
from
1274-Comparison-in-Reporting
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamilCDISC
requested changes
Dec 19, 2025
Collaborator
RamilCDISC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran a validation using dev editor and updated the rule to have USUBJID also in output variables like following
Outcome:
Message: At least one expected variable is missing from dataset
Output Variables:
- USUBJID
- compared:
- $dataset_variables
- $expected_variables
The AE dataset in attached excel file has USUBJID column but engine returns column not found.
[
{
"executionStatus": "success",
"dataset": "ae.xpt",
"domain": "AE",
"variables": [
"$dataset_variables",
"$expected_variables",
"USUBJID"
],
"message": "At least one expected variable is missing from dataset",
"errors": [
{
"value": {
"$dataset_variables": [
"STUDYID",
"DOMAIN",
"USUBJID",
"AESEQ",
"AELNKID",
"AETERM",
"AELLT",
"AELLTCD",
"AEDECOD",
"AEPTCD",
"AEHLT",
"AEHLTCD",
"AEHLGT",
"AEHLGTCD",
"AEBDSYCD",
"AESOC",
"AESOCCD",
"AESEV",
"AEACN",
"AEREL",
"AEOUT",
"AESCAN",
"AESCONG",
"AESDISAB",
"AESDTH",
"AESHOSP",
"AESLIFE",
"AESOD",
"EPOCH",
"AESTDTC",
"AEENDTC",
"AESTDY",
"AEENDY",
"AEENRTPT",
"AEENTPT"
],
"$expected_variables": [
"AELLT",
"AELLTCD",
"AEPTCD",
"AEHLT",
"AEHLTCD",
"AEHLGT",
"AEHLGTCD",
"AEBODSYS",
"AEBDSYCD",
"AESOC",
"AESOCCD",
"AESER",
"AEACN",
"AEREL",
"AESTDTC",
"AEENDTC"
],
"USUBJID": "Not in dataset"
},
"dataset": "ae.xpt"
}
],
"compare_groups": [
[
"$dataset_variables",
"$expected_variables"
]
]
}
]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1274: Implements explicit inline comparison syntax for output variables in rules via a new compared: dict block within Output Variables, enabling N-way set-based comparisons (len >= 2) where the first variable serves as baseline and subsequent variables are compared against it. The implementation flattens all variables (siblings + compared children) for UI display while isolating comparison logic to only variables within compared blocks, always uses set-based (order-independent) comparison. Reporting now shows formatted comparison summaries (missing/extra items) followed by raw variable lists, with Excel multi-line rendering support.
Attached are the Rule and dataset used for testing:
CORE-000334.yaml
unit-test-coreid-CG0016-negative.xlsx