-
-
Notifications
You must be signed in to change notification settings - Fork 22
Add a GeneratorVariableTracker class to manage un/tracked variables
#1340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4c07dec to
ed39816
Compare
877deee to
9647cd1
Compare
GeneratorContext class to manage un/tracked variablesGeneratorVariableTracker class to manage un/tracked variables
|
Note that I am not done yet... |
|
Why the change from |
In the end, the idea is for the Now, I agree that this is getting a bit out of hands and this is why I am finishing this cosmetic work (!!) now and this is it. |
So that we don't have to pass it as a parameter the whole time.
hsorby
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this interface for the generator, I think it looks great.
nickerso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is a good change, but happy to let it through. I assume documentation and tutorial updates are imminent that will help users transition our code to all these new APIs.
Fixes issue #1339.