Skip to content

Conversation

@kurayami07734
Copy link
Contributor

Updated the response model for create entitlement route. Also added logic to conditionally set result params in parse_list_response.

Description

Fixes failure when entitlements are being created using the sdk.

Related Issues

Closes #91

Additional Information

Not really

Updated the response model for create entitlement route. Also
added logic to conditionally set result params in parse_list_response.
@kurayami07734
Copy link
Contributor Author

kurayami07734 commented Sep 3, 2025

Hey guys, just checking in. Have you guys gotten a chance to look at this PR?

@overide
Copy link

overide commented Sep 8, 2025

Hey, we are also facing this issue, and this MR seems to be fixing it.

@abhinav2712
Copy link

hey @cb-sriramthiagarajan , Please have a look, we are facing issues,this MR fixed it

@cb-sriramthiagarajan
Copy link
Collaborator

Hi @abhinav2712 @overide @kurayami07734, thank you for raising this. We're looking into this and will get back soon.

@cb-alish cb-alish merged commit 154fd45 into chargebee:master Oct 10, 2025
@cb-alish
Copy link
Collaborator

Hi @kurayami07734, thanks a lot for taking the time to raise this PR. We've included the changes in our latest release (#100). The field list: List[ListEntitlementResponse] should have been list: List[CreateEntitlementResponse], as the list and create responses may diverge in the future. This has been corrected by our SDK generator in the subsequent PR. Apologies for the delayed response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failure in creating entitlements via sdk

5 participants