Skip to content

Conversation

@kianmeng
Copy link
Contributor

@kianmeng kianmeng commented May 9, 2022

List of other changes:

  • remove trailing spaces
  • missing missing date to changelog
  • add badges for quick overview

Screenshot:
Screenshot-20220509173346-2756x1572

Copy link
Owner

@choptastic choptastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I man, I just realized I started the "code review" comments here, but never submitted them.

If you're willing to update this, I'd love it, and if not, I can do it, since it's been sitting here for so long because I don't know how to use github, apparently.

Thanks!

@kianmeng kianmeng force-pushed the generate-doc-using-rebar3-ex-doc branch from 63d2fcf to 0f08be7 Compare August 12, 2023 03:17
List of other changes:
- remove trailing spaces
- missing missing date to changelog
- add badges for quick overview
@kianmeng kianmeng force-pushed the generate-doc-using-rebar3-ex-doc branch from 0f08be7 to c46f011 Compare August 12, 2023 03:22
@kianmeng
Copy link
Contributor Author

@choptastic I can't seem to get this to work on my local environment with recent rebar3_ex_doc, see jelly-beam/rebar3_ex_doc#60. Maybe it will work on your environment?

@choptastic
Copy link
Owner

Hi @kianmeng , you're right, I'm experiencing this as well.

If I have some time tonight, I may cut my elixir teeth and tinker with this to see if I can troubleshoot it.

Very interesting problem.

@kianmeng
Copy link
Contributor Author

@choptastic I believe there is a fix for it, see jelly-beam/rebar3_ex_doc#60 (comment)

@choptastic
Copy link
Owner

Excellent! I did indeed see that. Thanks again!

@choptastic
Copy link
Owner

Oh, and thank you for making those small corrections. I will merge them in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants