fix(clerk-js): Reload client in setActive when session not found #7349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setActive is called with a session ID that doesn't exist in the local client (e.g., a newly created impersonation session via ticket), the client is now reloaded to fetch the new session before activation. This fixes impersonation in CSR multi-session apps when the admin already has an existing session on the target app.
🦋 Changeset detectedLatest commit: c9860ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When setActive is called with a session ID that doesn't exist in the local client (e.g., a newly created impersonation session via ticket), the client is now reloaded to fetch the new session before activation.
This fixes impersonation in CSR multi-session apps when the admin already has an existing session on the target app.
Fixes USER-4134
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change