Replacing "position" settings for "route" settings #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @cloakedcode,
Thank you for all the effort to get the dockable probe into the main branch.
I recently put my own probe together using the README and videos of Annex-Engineering/Quickdraw_Probe. Once I got to the Klipper integration I noticed your PR and used this branch to get the probe working. Unfortunately I seem to have my dock set up in an unusual way so I couldn't get it completely right using only the
approach_position,detach_positionanddock_position. On top of this there seemed to be some unnecessary moves, making the attach/dock process only take longer.This made me think I might not be the only one with an unusual dock setup and instead of adding more
_positionsettings I decided to go with just two_routesettings. This could prevent unsupported edge cases in the future and reduce code complexity.My config now looks like this:
This moves the toolhead along the defined coordinates for attaching the probe and docking the probe respectively.
In the process of improving the attach and dock code I removed the vector and distance functions as they seemed no longer needed. Please let me know if I threw out the baby with the bathwater.
To keep the toolhead from crashing into anything I added a couple of
_align_z()'s, just to be safe.The code changes have only been tested on my own setup.
The documentation hasn't been updated to match the code changes yet. If the code changes are to be merged I will of course update the documentation as well.