Add basic support for redis queue. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradrydzewski
requested changes
Aug 2, 2017
Contributor
bradrydzewski
left a comment
bradrydzewski
left a comment
There was a problem hiding this comment.
I definitely think a redis client would be awesome. Added some initial comments. Also needs unit tests :)
|
|
||
| // WithProject configures the Pubsub client with the named project. | ||
| func WithRedisAddr(addr string) Option { | ||
| return func(opts *Options) { |
Contributor
There was a problem hiding this comment.
we can name WithAddr since the package name will be used by package consumers redis.WithAddr
redis/opts.go
Outdated
| // Option configures the Google Cloud pubsub client. | ||
| type Option func(*Options) | ||
|
|
||
| // WithProject configures the Pubsub client with the named project. |
redis/opts.go
Outdated
| } | ||
| } | ||
|
|
||
| func WithRedisPassword(password string) Option { |
Contributor
There was a problem hiding this comment.
rename to redis.WithPassword
redis/opts.go
Outdated
| } | ||
| } | ||
|
|
||
| func WithRedisDB(db int) Option { |
Contributor
There was a problem hiding this comment.
rename to redis.WithDB
redis/opts.go
Outdated
| } | ||
| } | ||
|
|
||
| func WithRedisQueueName(queueName string) Option { |
Contributor
There was a problem hiding this comment.
rename to redis.WithQueueName
|
|
||
| opts *Options | ||
| client *redis.Client | ||
| running map[string]*entry |
Contributor
There was a problem hiding this comment.
I think we should store this information in redis so that we can restart the redis server or drone server without losing the state of the queue.
Author
There was a problem hiding this comment.
I will try. thanks for reply.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic support for redis queue.