Skip to content

plugins/explain.py: Added explanation for "do not ask to ask". #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yashasingh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

plugins/explain.py: Added explanation for "do not ask to ask". #404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion plugins/explain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,19 @@ class Explain(BotPlugin):
'newcomer Pull Request\n- review at least a difficulty/'
'newcomer Pull Request\n- merge a difficulty/low Pull '
'Request\n- review at least a difficulty/low or higher '
'Pull Request'
'Pull Request',
'do not ask to ask': 'This seems a lazy way of asking your question '
'Don\'t take it personally. It\'s just that '
Copy link
Member

@Mixih Mixih Dec 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use double quotes around the whole string instead of escaping the single quotes. That way you can keep the single quotes in the string more readable. (this comment applies to all of the instances)

'you\'re asking for more than what you think '
'you\'re asking. The solution is not to simply '
Copy link
Member

@Mixih Mixih Dec 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the sentance The solution is not to simply [snip]... is too wordy. Please reword it to be more concise.

'question people about them, but just to '
'ask for your piece of information by actaully '
Copy link
Member

@Mixih Mixih Dec 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in "actually"

'formalizing it in words. Someone who is idling '
'on the channel and only occasionally glances '
'at what\'s going on is unlikely to answer '
'to your "asking to ask" question, but your '
Copy link
Member

@Mixih Mixih Dec 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete to

'actual problem description may pique their '
'interest and get them to answer.'
}

ERROR_MSG = (
Expand Down