Skip to content

Conversation

@jayvdb
Copy link
Member

@jayvdb jayvdb commented Nov 28, 2017

Reviewers Checklist

  • Appropriate logging is done.
  • Appropriate error responses.
  • Handle every possible exception.
  • Make sure there is a docstring in the command functions. Hint: Lookout for
    botcmd and re_botcmd decorators.
  • See that 100% coverage is there.
  • See to it that mocking is not done where it is not necessary.

@meetmangukiya
Copy link
Member

@gitmate-bot rebase

@gitmate-bot
Copy link

Hey! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost!

@gitmate-bot
Copy link

Automated rebase failed! Please rebase your pull request manually via the command line.

Error:
Command '['git', 'clone', '--depth', '1', 'rebase', '/tmp/tmpibsjp9gq']' returned non-zero exit status 128.

@jayvdb
Copy link
Member Author

jayvdb commented May 26, 2018

@gitmate-bot rebase

@gitmate-bot
Copy link

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@gitmate-bot
Copy link

Automated rebase with GitMate.io was successful! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants