Skip to content

Feature/unit tests #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
dxL1nus wants to merge 78 commits into
base: main
Choose a base branch
from
Draft

Feature/unit tests #79

dxL1nus wants to merge 78 commits into from

Conversation

@dxL1nus
Copy link
Contributor

@dxL1nus dxL1nus commented Dec 18, 2025

closes #70

!IMPORTANT: This PR can only be safely merged after PR #63

This is the PR for the first unit tests for the ojs-codecheck plugin. The tests are mainly for the RetrieveReserveIdentifiers scripts and can act as a guideline/ template on how to write other unit tests for the remaining class files.

Run the tests with the following command from the PKP OJS root directory:

lib/pkp/lib/vendor/phpunit/phpunit/phpunit -c lib/pkp/tests/phpunit.xml plugins/generic/codecheck/tests/

Results:
grafik

find the test coverage in the following file:

/var/www/html/ojs-tests/lib/pkp/tests/results/index.html
grafik

dxL1nus added 30 commits October 8, 2025 21:40
@dxL1nus
Added first Certificate Identifier Field to submission form
e899d10 
(codecheckers#48)
@dxL1nus
Updated Certificate ID Fields to now include Reserve and Remove Buttons
19a91f5 
codecheckers#48)
@dxL1nus
Small comments on what to do next github.com/codecheckers/issues/48)
8b0dee2
@dxL1nus
Remove Identifier button now removes ID from Input correctly (codeche…
2788bb7 
…ckers#48)
@dxL1nus
Added initial Selects for Venue Type and Name (codecheckers#48)
45c90d5
@dxL1nus
New labels for Venue Name and Venue Type (codecheckers#48)
1c85bed
@dxL1nus
Intitial Structure for AJAX Call, but fails at the moment (codechecke…
4ed37f3 
…rs#48)
@dxL1nus
Changed Ajax Path to now use API Hook provided to me by @Subhanaliweb …
315d9d6 
…(github.com/codecheckers/issues/48)
@dxL1nus
Minor changes to API, but still not working yet (codecheckers#48)
96718f6
@dxL1nus
Trying to fix the API not found bug (but not successful so far) codec…
fc633ee 
…heckers#48
@dxL1nus
Small updates, but still API 404 Error (codecheckers#48)
4d028af
@dxL1nus
LoadHandler Hook now calls my APIHandler, but it seems, that APIHandl…
4fa5d51 
…er might be deprecated (codecheckers#48)
@dxL1nus
Refactored RetrieveReserveIdentifiers to have separate files for each…
203a04e 
… class (codecheckers#48 , codecheckers#11)
@dxL1nus
Refactored Set to now use custom UniqueArray, for better support (cod…
6c76726 
…echeckers#48) (codecheckers#11)
@dxL1nus
added require statement for own composer autoloader file (codechecker…
50e6181 
…s#48)
@dxL1nus
Fixed API bug by implemented our very own journal/codecheck_api/{ourA…
d72ad4b 
…piRoute} (codecheckers#48)
@dxL1nus
Finally VenueTypes and VenueNames is shown in the Selects after API w…
6c48b63 
…orks (codecheckers#48)
@dxL1nus
Reserving of Identifier now works with Button through UI (https://git…
51bc3a3 
…hub.com/codecheckers/ojs-codecheck/issues/489
@dxL1nus
Now returns link to the newly created GitHub issue (codecheckers#48)
649e5aa
@dxL1nus
Link to newly created Github Issue is now displayed below Certificate…
c1c3693 
… Identifier Selects (codecheckers/issues/48)
@dxL1nus
Used refactor by subhan to refactor my fields to use Vue.js (codechec…
fefecd9 
…kers#48)
@dxL1nus
Changed small css (codecheckers#48)
26c9f40
@dxL1nus
Deleted old CertificateRetrievingAndCreation.php file (codecheckers#48)
6ddb28f
@dxL1nus
Added support for own codecheck Route in OJS API through existing rou…
91681bd 
…tes like users or submission codecheckers#48)
@dxL1nus
Selects and Reserve Button are now disabled once the new Identifier i…
ddb0378 
…s reserved (codecheckers#48)
@dxL1nus
Initial commit for this branch so the UI branch can be merged into it
8076deb
@dxL1nus
Merged UI branch into this branch codecheckers#64
f9d36e4
@dxL1nus
Certificate Identifier Fields now in Metadata Form codecheckers#64
2985718
@dxL1nus
Began to reimplement Certificate Identifier Fields without extra Comp…
38b9afd 
…onent (codecheckers#64)
@dxL1nus
Doesn't quite work yet codecheckers#64
94432d1
dxL1nus and others added 25 commits November 13, 2025 20:09
@dxL1nus
No authorize checks for correct role assignments codecheckers#64
3177082
@dxL1nus
Initial structure for unittests plus first tests for getRawIdentifier c…
a6aa31b 
…odecheckers#70
@dxL1nus
Found command to run unittests codecheckers#70
332fb6d
@dxL1nus
Added Comments and PHPDoc for all functions I wrote codecheckers#69
16bccc1
@dxL1nus
Changed behavior of getRawIdentifier based on unittests codecheckers#70
d58b905
@dxL1nus
New behavior for getRawIdentifier
7ea28bd
@dxL1nus
Added new unit-test for getRawIdentifier() codecheckers#70
457d032
@dxL1nus
Update README.md to include Guide on how to run Unit Tests codechecke…
d95b477 
…rs#70
@dxL1nus
Update README.md to include guide for registering new Api Endpoints c…
e07650d 
…odecheckers#48, codecheckers#64
@dxL1nus
Updated Venue Names to now fetch from Codecheck Rest Api codecheckers#48
4c227c9 
, codecheckers#64
@dxL1nus
CertificateIdentifierList is now fully covered codecheckers#70
4760d88
@dxL1nus
Simplified setup of CertificateIdentifierList tests codecheckers#70
15fe422
@dxL1nus
Added Unit Tests for CertificateIdentifier codecheckers#70
aa09da4
@dxL1nus
Added further Unit tests for Codecheck Venues codecheckers#70
4c10b7d
@dxL1nus
Added some more UnitTests for the GitHub Api Parser codecheckers#70
88322fc
@dxL1nus
Correct Api path
eec777e
@dxL1nus
New version of subhan now works
6bc61f4
@dxL1nus
Merged newest commits from upstream
3bebfae
@dxL1nus
Updated the UI to be up to date with the newest version of codecheck …
f4a98cb 
…metadata form codecheckers#48 codecheckers#64
@dxL1nus
Added last UnitTests to reach 100% coverage codecheckers#70
ed35c9c
@dxL1nus
Fixed bug on main codecheckers#59
ae18d6b
@dxL1nus
Merged main into my branch codecheckers#48 codecheckers#64
2bc7131
@dxL1nus
Merged main and adapted to latest version of RetrieveReserveIdentifier …
2895b1d 
…codecheckers#70
@dxL1nus
Added unit test for Unique Array from factory method codecheckers#70
86b8ea9
@dxL1nus
Fixed Merge conflict in Readme Test Documentation codecheckers#70
5661235
@dxL1nus dxL1nus requested a review from nuest December 18, 2025 18:17
@dxL1nus dxL1nus self-assigned this Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nuest nuest Awaiting requested review from nuest

Assignees

@dxL1nus dxL1nus

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add first Unit tests

1 participant

@dxL1nus