Skip to content

⚡️ Speed up method lbank.parse_transaction_status by 31% #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡️ Speed up method lbank.parse_transaction_status by 31% #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 17 additions & 16 deletions python/ccxt/async_support/lbank.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,22 @@
from ccxt.base.decimal_to_precision import TICK_SIZE
from ccxt.base.precise import Precise

LBANK_TRANSACTION_STATUSES = {
'deposit': {
'1': 'pending',
'2': 'ok',
'3': 'failed',
'4': 'canceled',
'5': 'transfer',
},
'withdrawal': {
'1': 'pending',
'2': 'canceled',
'3': 'failed',
'4': 'ok',
},
}


class lbank(Exchange, ImplicitAPI):

Expand Down Expand Up @@ -2297,22 +2313,7 @@ async def withdraw(self, code: str, amount: float, address: str, tag: Str = None
}

def parse_transaction_status(self, status, type):
statuses: dict = {
'deposit': {
'1': 'pending',
'2': 'ok',
'3': 'failed',
'4': 'canceled',
'5': 'transfer',
},
'withdrawal': {
'1': 'pending',
'2': 'canceled',
'3': 'failed',
'4': 'ok',
},
}
return self.safe_string(self.safe_value(statuses, type, {}), status, status)
return self.safe_string(self.safe_value(LBANK_TRANSACTION_STATUSES, type, {}), status, status)

def parse_transaction(self, transaction: dict, currency: Currency = None) -> Transaction:
#
Expand Down
Loading