Skip to content

⚡️ Speed up method SparseVectorIndexConfig.validate_embedding_function_field by 69% #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method SparseVectorIndexConfig.validate_embedding_function_field by 69% #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions chromadb/api/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@
import struct
import math

_cached_protocol_signature = None

# Re-export types from chromadb.types
__all__ = [
"Metadata",
Expand Down Expand Up @@ -1480,10 +1482,10 @@ def validate_sparse_embedding_function(
sparse_vector_function: SparseEmbeddingFunction[Embeddable],
) -> None:
"""Validate that a sparse vector function conforms to the SparseEmbeddingFunction protocol."""
function_signature = signature(
sparse_vector_function.__class__.__call__
).parameters.keys()
protocol_signature = signature(SparseEmbeddingFunction.__call__).parameters.keys()
function_signature = tuple(
signature(sparse_vector_function.__class__.__call__).parameters.keys()
)
protocol_signature = _get_protocol_signature()

if not function_signature == protocol_signature:
raise ValueError(
Expand All @@ -1492,6 +1494,15 @@ def validate_sparse_embedding_function(
)


def _get_protocol_signature():
global _cached_protocol_signature
if _cached_protocol_signature is None:
_cached_protocol_signature = tuple(
signature(SparseEmbeddingFunction.__call__).parameters.keys()
)
return _cached_protocol_signature


# Index Configuration Types for Collection Schema
class FtsIndexConfig(BaseModel):
"""Configuration for Full-Text Search index. No parameters required."""
Expand Down