⚡️ Speed up function HttpClient by 8%

[codeflash-ai]

📄 8% (0.08x) speedup for HttpClient in chromadb/__init__.py

⏱️ Runtime : 10.5 microseconds → 9.73 microseconds (best of 5 runs)

📝 Explanation and details

The optimized code achieves an 8% speedup through two main optimizations:

1. Conditional Type Conversion: Instead of unconditionally calling str(), int(), and bool() on all parameters, the optimized version first checks if the value is already the correct type using isinstance(). This avoids unnecessary type conversions when parameters are already properly typed (which is the common case).

2. Efficient Attribute Access: The original code checks settings attributes using settings.chroma_server_host and settings.chroma_server_host != host, which can trigger attribute access twice. The optimized version uses getattr(settings, "chroma_server_host", None) to get the value once, then checks if it's not None before comparing.

Performance Impact: The type checking optimization is particularly effective because most callers pass correctly-typed parameters (strings for host/tenant/database, int for port, bool for ssl). The isinstance() check is faster than the actual type conversion, so we only pay the conversion cost when needed. The test results show this works especially well for conflict scenarios - the host conflict test runs 16-20% faster, demonstrating the benefit when dealing with pre-configured settings objects that already have the correct types.

These optimizations maintain identical behavior while reducing unnecessary work in the common case where parameters are already correctly typed.

✅ Correctness verification report:

Test	Status
⚙️ Existing Unit Tests	✅ 47 Passed
🌀 Generated Regression Tests	✅ 21 Passed
⏪ Replay Tests	🔘 None Found
🔎 Concolic Coverage Tests	🔘 None Found
📊 Tests Coverage	100.0%

⚙️ Existing Unit Tests and Runtime

🌀 Generated Regression Tests and Runtime

from typing import Dict, Optional

# imports
import pytest
from chromadb.__init__ import HttpClient


# Dummy classes and constants to enable testing without real chromadb dependencies.
class Settings:
    def __init__(self):
        self.chroma_api_impl = None
        self.chroma_server_host = None
        self.chroma_server_http_port = None
        self.chroma_server_ssl_enabled = None
        self.chroma_server_headers = None

DEFAULT_TENANT = "default_tenant"
DEFAULT_DATABASE = "default_database"

class ClientAPI:
    def __init__(self, tenant, database, settings):
        self.tenant = tenant
        self.database = database
        self.settings = settings

class ClientCreator(ClientAPI):
    pass
from chromadb.__init__ import HttpClient

# unit tests

# ---------- BASIC TEST CASES ----------












def test_settings_host_conflict():
    """Test ValueError when settings.chroma_server_host conflicts with host."""
    s = Settings()
    s.chroma_server_host = "otherhost"
    with pytest.raises(ValueError) as excinfo:
        HttpClient(host="localhost", settings=s) # 2.76μs -> 2.36μs (16.8% faster)

def test_settings_port_conflict():
    """Test ValueError when settings.chroma_server_http_port conflicts with port."""
    s = Settings()
    s.chroma_server_http_port = 1234
    with pytest.raises(ValueError) as excinfo:
        HttpClient(port=5678, settings=s) # 2.54μs -> 2.62μs (3.39% slower)










#------------------------------------------------
import sqlite3
from types import SimpleNamespace
from typing import Dict, Optional

# imports
import pytest
from chromadb.__init__ import HttpClient

# --- Begin: Minimal stubs for dependencies to allow tests to run ---

class Settings:
    def __init__(self):
        self.chroma_api_impl = None
        self.chroma_server_host = None
        self.chroma_server_http_port = None
        self.chroma_server_ssl_enabled = None
        self.chroma_server_headers = None

DEFAULT_DATABASE = "default_db"
DEFAULT_TENANT = "default_tenant"

class ClientAPI:
    def __init__(self, tenant, database, settings):
        self.tenant = tenant
        self.database = database
        self.settings = settings

class ClientCreator(ClientAPI):
    pass
from chromadb.__init__ import HttpClient

# unit tests

# -----------------------------
# Basic Test Cases
# -----------------------------





def test_settings_object_passed():
    """Test passing a pre-existing Settings object."""
    s = Settings()
    s.chroma_server_host = None
    s.chroma_server_http_port = None
    codeflash_output = HttpClient(settings=s, host="h", port=1); client = codeflash_output

# -----------------------------
# Edge Test Cases
# -----------------------------

@pytest.mark.parametrize("host", [123, 45.6, True, None])
def test_host_type_coercion(host):
    """Test that host is coerced to string."""
    codeflash_output = HttpClient(host=host); client = codeflash_output

@pytest.mark.parametrize("port", ["1234", 1234.0, True])
def test_port_type_coercion(port):
    """Test that port is coerced to int."""
    codeflash_output = HttpClient(port=port); client = codeflash_output

@pytest.mark.parametrize("ssl", [1, "True", "false", 0])
def test_ssl_type_coercion(ssl):
    """Test that ssl is coerced to bool."""
    codeflash_output = HttpClient(ssl=ssl); client = codeflash_output

@pytest.mark.parametrize("tenant", [123, True, None])
def test_tenant_type_coercion(tenant):
    """Test that tenant is coerced to string."""
    codeflash_output = HttpClient(tenant=tenant); client = codeflash_output

@pytest.mark.parametrize("database", [123, True, None])
def test_database_type_coercion(database):
    """Test that database is coerced to string."""
    codeflash_output = HttpClient(database=database); client = codeflash_output


def test_settings_host_conflict():
    """Test ValueError if settings.chroma_server_host conflicts with host."""
    s = Settings()
    s.chroma_server_host = "something_else"
    with pytest.raises(ValueError) as excinfo:
        HttpClient(settings=s, host="hostx") # 2.68μs -> 2.23μs (20.3% faster)

def test_settings_port_conflict():
    """Test ValueError if settings.chroma_server_http_port conflicts with port."""
    s = Settings()
    s.chroma_server_http_port = 5555
    with pytest.raises(ValueError) as excinfo:
        HttpClient(settings=s, port=9999) # 2.54μs -> 2.52μs (0.913% faster)

def test_settings_host_and_port_match():
    """Test that no error is raised if settings host/port match input."""
    s = Settings()
    s.chroma_server_host = "abc"
    s.chroma_server_http_port = 123
    codeflash_output = HttpClient(settings=s, host="abc", port=123); client = codeflash_output

To edit these changes git checkout codeflash/optimize-HttpClient-mh7ncfoi and push.