Skip to content

⚡️ Speed up function to_proto_update_metadata by 6% #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function to_proto_update_metadata by 6% #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions chromadb/proto/convert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,13 +217,14 @@ def to_proto_metadata_update_value(
# Be careful with the order here. Since bools are a subtype of int in python,
# isinstance(value, bool) and isinstance(value, int) both return true
# for a value of bool type.
if isinstance(value, bool):
t = type(value)
if t is bool:
return chroma_pb.UpdateMetadataValue(bool_value=value)
elif isinstance(value, str):
elif t is str:
return chroma_pb.UpdateMetadataValue(string_value=value)
elif isinstance(value, int):
elif t is int:
return chroma_pb.UpdateMetadataValue(int_value=value)
elif isinstance(value, float):
elif t is float:
return chroma_pb.UpdateMetadataValue(float_value=value)
# None is used to delete the metadata key.
elif value is None:
Expand Down