Skip to content

⚡️ Speed up function from_proto_segment by 64% #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function from_proto_segment by 64% #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions chromadb/proto/convert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@
VectorQueryResult,
)

_SEGMENT_SCOPE_FAST_MAP = {
chroma_pb.SegmentScope.VECTOR: SegmentScope.VECTOR,
chroma_pb.SegmentScope.METADATA: SegmentScope.METADATA,
chroma_pb.SegmentScope.RECORD: SegmentScope.RECORD,
}


class ProjectionRecord(TypedDict):
id: str
Expand Down Expand Up @@ -158,18 +164,16 @@ def from_proto_submit(


def from_proto_segment(segment: chroma_pb.Segment) -> Segment:
has_metadata = segment.HasField("metadata")
file_paths = {name: list(paths.paths) for name, paths in segment.file_paths.items()}

return Segment(
id=UUID(hex=segment.id),
type=segment.type,
scope=from_proto_segment_scope(segment.scope),
scope=_from_proto_segment_scope_fast(segment.scope),
collection=UUID(hex=segment.collection),
metadata=from_proto_metadata(segment.metadata)
if segment.HasField("metadata")
else None,
file_paths={
name: [path for path in paths.paths]
for name, paths in segment.file_paths.items()
},
metadata=from_proto_metadata(segment.metadata) if has_metadata else None,
file_paths=file_paths,
)


Expand Down Expand Up @@ -686,3 +690,12 @@ def from_proto_knn_batch_result(
[from_proto_knn_projection_record(record) for record in result.records]
for result in results.results
]


def _from_proto_segment_scope_fast(
segment_scope: chroma_pb.SegmentScope,
) -> SegmentScope:
try:
return _SEGMENT_SCOPE_FAST_MAP[segment_scope]
except KeyError:
raise RuntimeError(f"Unknown segment scope {segment_scope}")