Skip to content

⚡️ Speed up function get_role_based_routes by 24% #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function get_role_based_routes by 24% #442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions litellm/proxy/auth/auth_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import asyncio
import re
import time
from typing import TYPE_CHECKING, Any, Dict, List, Literal, Optional, Union, cast
from typing import TYPE_CHECKING, Any, Dict, List, Literal, Optional, Union

from fastapi import Request, status
from pydantic import BaseModel
Expand Down Expand Up @@ -45,7 +45,6 @@
NewTeamRequest,
ProxyErrorTypes,
ProxyException,
RoleBasedPermissions,
SpecialModelNames,
UserAPIKeyAuth,
)
Expand Down Expand Up @@ -737,16 +736,18 @@ def _get_role_based_permissions(
"""
Get the role based permissions from the general settings.
"""
role_based_permissions = cast(
Optional[List[RoleBasedPermissions]],
general_settings.get("role_permissions", []),
)
if role_based_permissions is None:
# Avoid casting to Optional[List[RoleBasedPermissions]], since we always want a list here
role_based_permissions = general_settings.get("role_permissions")
if not role_based_permissions:
return None

for role_based_permission in role_based_permissions:
if role_based_permission.role == rbac_role:
return getattr(role_based_permission, key)
# Use generator expression with next() for faster lookup
role_based_permission = next(
(rbp for rbp in role_based_permissions if rbp.role == rbac_role),
None,
)
if role_based_permission is not None:
return getattr(role_based_permission, key)

return None

Expand Down