Skip to content

⚡️ Speed up function can_user_call_model by 27% #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function can_user_call_model by 27% #446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 26 additions & 7 deletions litellm/proxy/auth/auth_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1473,13 +1473,27 @@ def _can_object_call_model(
)
return True


# If allowed models contains the wildcard or all models marker, grant early
# Check and avoid repeating expensive _check_model_access_helper
if not models or "*" in models or SpecialModelNames.all_proxy_models.value in models:
return True

potential_models = [model]
if model in litellm.model_alias_map:
potential_models.append(litellm.model_alias_map[model])
elif llm_router and model in llm_router.model_group_alias:
_model = llm_router._get_model_from_alias(model)
if _model:
potential_models.append(_model)
model_in_litellm_alias = litellm.model_alias_map.get(model)
if model_in_litellm_alias is not None:
potential_models.append(model_in_litellm_alias)
elif llm_router is not None:
# Avoid double dict lookup+attribute - combine
model_group_alias = getattr(llm_router, "model_group_alias", None)
if model_group_alias and model in model_group_alias:
_model = llm_router._get_model_from_alias(model)
if _model:
potential_models.append(_model)

# check model access for alias + underlying model - allow if either is in allowed models
# shortcut if any potential model is allowed, do not check remaining
# _check_model_access_helper does a lot - avoid calling unnecessarily

## check model access for alias + underlying model - allow if either is in allowed models
for m in potential_models:
Expand Down Expand Up @@ -1594,7 +1608,12 @@ async def can_user_call_model(
if user_object is None:
return True

if SpecialModelNames.no_default_models.value in user_object.models:
# Use set lookup for faster membership check for no_default_models pattern
user_models = user_object.models
# If user_models is not a list, fallback to original logic
# But practically, user_models is always List[str].
no_default_value = SpecialModelNames.no_default_models.value
if hasattr(user_models, "__contains__") and no_default_value in user_models:
raise ProxyException(
message=f"User not allowed to access model. No default model access, only team models allowed. Tried to access {model}",
type=ProxyErrorTypes.key_model_access_denied,
Expand Down