Skip to content

C2LC-400: Removed seemingly unnecessary margin-bottom from toggle switch inner circle. #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
the-t-in-rtf wants to merge 5 commits into
base: develop-1.0
Choose a base branch
from
Open

C2LC-400: Removed seemingly unnecessary margin-bottom from toggle switch inner circle. #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dec9efc
C2LC-400: Removed seemingly unnecessary margin-bottom from toggle swi…
the-t-in-rtf Jun 23, 2021
027ed19
C2LC-400: Removed unneeded bottom margin from audio feedback toggle.
the-t-in-rtf Jun 28, 2021
aa107ee
C2LC-400: Removed unneeded margin top from toggle inner circle.
the-t-in-rtf Jun 30, 2021
a7be754
C2LC-400: Standardised toggle heights to fix alignment issues.
the-t-in-rtf Jun 30, 2021
09954c1
Merge remote-tracking branch 'upstream/develop-1.0' into C2LC-400
the-t-in-rtf Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/AudioFeedbackToggleSwitch.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

.AudioFeedbackToggleSwitch {
background-color: #B9BEC6;
max-height: 2.6rem;
width: 4.5rem;

&:focus {
Expand All @@ -11,8 +10,6 @@

.ToggleSwitch__switch-inner-circle {
background-color: white;
margin-bottom: 0.2rem;
margin-top: 0;

svg {
path {
Expand Down
4 changes: 1 addition & 3 deletions src/ToggleSwitch.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

.ToggleSwitch {
width: 4.3rem;
max-height: 2.5rem;
max-height: 2.6rem;
background: #c4c4c4;
border-radius: 1.2rem;
padding: 0.3rem;
Expand All @@ -26,8 +26,6 @@
background: #F1F1F1;
border-radius: 50%;
display: inline-block;
margin-bottom: 0.1rem;
Copy link
Contributor

@chosww chosww Jun 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently this margin has no effect at all -- I changed it to 100rem and still look the same, which means that we can get rid of margin-top on the next line as well.

Copy link
Contributor Author

@the-t-in-rtf the-t-in-rtf Jun 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cleaned this up and a similar one in the Audio Feedback toggle. I checked the expand add node as well.

margin-top: -0.05rem;
padding: 0.2rem;
}

Expand Down