🤖 feat: PTC subagent support and compatibility fixes #1351
Merged
+171
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Member
Author
|
The exclusive PTC experiment flag intentionally overrides tool policy. When exclusive mode is enabled, Resolving as intentional design. |
- Remove mux. prefix from nested tool names in quickjsRuntime - Inherit PTC experiments to subagents spawned via task tool - Add timeout_secs parameter to code_execution (default 5min, max 1hr) - Exclude agent_report from sandbox (must be top-level for taskService) - Add task tools to BridgeableToolName for type generation - Add task tool rendering to NestedToolRenderer
Apply applyToolPolicy to the final tool set in exclusive PTC mode, matching the behavior in supplement mode. This ensures admin/preset policies can properly enable, disable, or require code_execution.
This reverts commit c16dfec.
ethanndickson
force-pushed
the
ptc-compat-fc5t
branch
from
e2a7bbc to
dcb5adf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enables PTC (Programmatic Tool Calling) to work properly with subagents and fixes several compatibility issues.
Changes
Core Fixes
mux.prefix: Nested tool calls incode_executionnow emit bare tool names (bash,file_read) instead ofmux.bash,mux.file_readagent_reportfrom sandbox: Must be called as top-level tool fortaskServiceto read args from historytimeout_secstocode_execution: Default 5 minutes, max 1 hour - needed for subagents that can take 5-15+ minutesPTC Experiments Inheritance
tasktool inherit parent's PTC experimentstaskExperimentsto workspace config for restart-safe persistenceUI Updates
task,task_await,task_list,task_terminate) toNestedToolRenderernormalizeToolName()functionTesting
Future
Unify where we convert tool names into the pretty UI components. Right now we have to update the list in two places when we add a new tool,
NestedToolRendererandtoolRendererGenerated with
mux• Model:anthropic:claude-opus-4-5• Thinking:high