🤖 fix: bundle TypeScript libs for PTC type validation in production #1353
+85
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanndickson
force-pushed
the
tooling-yewq
branch
from
34181c2 to
39fbed8
Compare
- Replace nanoid with crypto.randomBytes (nanoid was dev-only transitive dep) - Copy TypeScript lib files (es5-es2020) to dist/typescript-lib/ during build - Rename to .d.ts.txt to bypass electron-builder's hardcoded .d.ts filter electron-userland/electron-builder#5064 - Custom compiler host in typeValidator.ts resolves libs from bundled dir - Collapse code_execution Result boxes by default - Add spacing between consecutive code execution blocks - Update tool description to emphasize batching over Promise.all note
ethanndickson
force-pushed
the
tooling-yewq
branch
from
39fbed8 to
2815a5f
Compare
ethanndickson
changed the title
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes PTC (Programmatic Tool Calling) failing in production builds due to missing TypeScript lib files.
Problems Fixed
nanoid not found -
nanoidwas only a transitive dev dependency (via postcss). Replaced withcrypto.randomBytes.TypeScript lib files missing - The type validator uses TypeScript's compiler API which needs
lib.es2020.d.tsand dependencies. electron-builder has a hardcoded filter that excludes all.d.tsfiles from the asar (electron-builder#5064).Solution
dist/typescript-lib/during build.d.ts.txtto bypass electron-builder's filtertypeValidator.tsmaps TypeScript's requests back to the renamed filesOther Changes
Generated with
mux• Model:anthropic:claude-opus-4-5• Thinking:high