Honda - support RDX 3G variants with brake booster (alt_brake) #2973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaharathBathula
left a comment
BaharathBathula
left a comment
There was a problem hiding this comment.
Nice contribution. You might consider separating this logic into a smaller
helper function to improve readability and testability.
Contributor
Author
Not sure what you are recommending? Long term #2919 is cleaner, but if comma prefers less of a change than this PR will solve the short term issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some 3rd gen RDX models have a brake booster and thus need the alt-brake flag autodetected.
alt-brake causes the correct brakepressed carstate to be set.
d9ac1a7b6755fff9/0000001f--8e7db88e99