-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Honda - Euro Civic Type R FK8 support #2986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mvl-boston
wants to merge
14
commits into
commaai:master
Choose a base branch
from
mvl-boston:ctr
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added params from here
{'carParams': {'alphaLongitudinalAvailable': False,
'alternativeExperience': 0,
'autoResumeSng': True,
'brand': 'mock',
'carFingerprint': 'MOCK',
'carFw': [{'address': 417001457,
'brand': 'honda',
'bus': 1,
'ecu': 'gateway',
'fwVersion': b'38897-TBA-A020\x00\x00',
'logging': False,
'obdMultiplexing': True,
'request': [b'"\xf1\x81'],
'responseAddress': 417001967,
'subAddress': 0},
{'address': 416952561,
'brand': 'honda',
'bus': 1,
'ecu': 'eps',
'fwVersion': b'39990-TGH-J020\x00\x00',
'logging': False,
'obdMultiplexing': True,
'request': [b'"\xf1\x81'],
'responseAddress': 417001776,
'subAddress': 0},
{'address': 416944369,
'brand': 'honda',
'bus': 1,
'ecu': 'programmedFuelInjection',
'fwVersion': b'37805-5BF-E030\x00\x00',
'logging': True,
'obdMultiplexing': True,
'request': [b'"\xf1\x81'],
'responseAddress': 417001744,
'subAddress': 0},
{'address': 416964849,
'brand': 'honda',
'bus': 1,
'ecu': 'combinationMeter',
'fwVersion': b'78109-TGH-E310\x00\x00',
'logging': True,
'obdMultiplexing': True,
'request': [b'"\xf1\x81'],
'responseAddress': 417001824,
'subAddress': 0},
{'address': 416950513,
'brand': 'honda',
'bus': 1,
'ecu': 'vsa',
'fwVersion': b'57114-TGH-A130\x00\x00',
'logging': False,
'obdMultiplexing': True,
'request': [b'"\xf1\x81'],
'responseAddress': 417001768,
'subAddress': 0},
{'address': 416986609,
'brand': 'honda',
'bus': 1,
'ecu': 'fwdCamera',
'fwVersion': b'36161-TGH-A020\x00\x00',
'logging': False,
'obdMultiplexing': True,
'request': [b'"\xf1\x81'],
'responseAddress': 417001909,
'subAddress': 0},
{'address': 416985329,
'brand': 'honda',
'bus': 1,
'ecu': 'fwdRadar',
'fwVersion': b'36802-TGH-A030\x00\x00',
'logging': False,
'obdMultiplexing': True,
'request': [b'"\xf1\x81'],
'responseAddress': 417001904,
'subAddress': 0},
{'address': 416961521,
'brand': 'honda',
'bus': 1,
'ecu': 'srs',
'fwVersion': b'77959-TGH-E220\x00\x00',
'logging': False,
'obdMultiplexing': True,
'request': [b'"\xf1\x81'],
'responseAddress': 417001811,
'subAddress': 0},
{'address': 417001457,
'brand': 'honda',
'bus': 1,
'ecu': 'gateway',
'fwVersion': b'\x0cH2462012\x00\x00\x00\x00 ',
'logging': True,
'obdMultiplexing': True,
'request': [b'"\xf1\x12'],
'responseAddress': 417001967,
'subAddress': 0},
{'address': 416952561,
'brand': 'honda',
'bus': 1,
'ecu': 'eps',
'fwVersion': b'\x0c BK7G255772C ',
'logging': True,
'obdMultiplexing': True,
'request': [b'"\xf1\x12'],
'responseAddress': 417001776,
'subAddress': 0},
{'address': 416944369,
'brand': 'honda',
'bus': 1,
'ecu': 'programmedFuelInjection',
'fwVersion': b'\x0e17-11-06 0131\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00',
'logging': True,
'obdMultiplexing': True,
'request': [b'"\xf1\x12'],
'responseAddress': 417001744,
'subAddress': 0},
{'address': 416950513,
'brand': 'honda',
'bus': 1,
'ecu': 'vsa',
'fwVersion': b'\x0b72920747323\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00',
'logging': True,
'obdMultiplexing': True,
'request': [b'"\xf1\x12'],
'responseAddress': 417001768,
'subAddress': 0},
{'address': 416986609,
'brand': 'honda',
'bus': 1,
'ecu': 'fwdCamera',
'fwVersion': b'\x0e11101711261084\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00',
'logging': True,
'obdMultiplexing': True,
'request': [b'"\xf1\x12'],
'responseAddress': 417001909,
'subAddress': 0},
{'address': 416964849,
'brand': 'honda',
'bus': 1,
'ecu': 'combinationMeter',
'fwVersion': b'\x18H3344390\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00',
'logging': True,
'obdMultiplexing': True,
'request': [b'"\xf1\x12'],
'responseAddress': 417001824,
'subAddress': 0},
{'address': 416985329,
'brand': 'honda',
'bus': 1,
'ecu': 'fwdRadar',
'fwVersion': b'\x0e04641711160A26\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00',
'logging': True,
'obdMultiplexing': True,
'request': [b'"\xf1\x12'],
'responseAddress': 417001904,
'subAddress': 0},
{'address': 416961521,
'brand': 'honda',
'bus': 1,
'ecu': 'srs',
'fwVersion': b'\x0bC1DQ009B14Y\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00',
'logging': True,
'obdMultiplexing': True,
'request': [b'"\xf1\x12'],
'responseAddress': 417001811,
'subAddress': 0},
{'address': 416952561,
'brand': 'honda',
'bus': 1,
'ecu': 'eps',
'fwVersion': b'39990-TGH-J020\x00\x00',
'logging': False,
'obdMultiplexing': False,
'request': [b'"\xf1\x81'],
'responseAddress': 417001776,
'subAddress': 0},
{'address': 416986609,
'brand': 'honda',
'bus': 1,
'ecu': 'fwdCamera',
'fwVersion': b'36161-TGH-A020\x00\x00',
'logging': False,
'obdMultiplexing': False,
'request': [b'"\xf1\x81'],
'responseAddress': 417001909,
'subAddress': 0},
{'address': 416985329,
'brand': 'honda',
'bus': 1,
'ecu': 'fwdRadar',
'fwVersion': b'36802-TGH-A030\x00\x00',
'logging': False,
'obdMultiplexing': False,
'request': [b'"\xf1\x81'],
'responseAddress': 417001904,
'subAddress': 0},
{'address': 416961521,
'brand': 'honda',
'bus': 1,
'ecu': 'srs',
'fwVersion': b'77959-TGH-E220\x00\x00',
'logging': False,
'obdMultiplexing': False,
'request': [b'"\xf1\x81'],
'responseAddress': 417001811,
'subAddress': 0}],
'carVin': 'SHHFK8790HU003163',
Checked over them again
Added whole new Civic Section
CAR.HONDA_CIVIC_TYPE_R_FK8: {
(Ecu.gateway, 0x18DAF1EF, 0): [b'38897-TBA-A020\x00\x00'], # Gateway
(Ecu.abs, 0x18DAF128, 0): [b'57114-TGH-A130\x00\x00'], # VSA / ABS / ESP
(Ecu.eps, 0x18DAF130, 0): [b'39990-TGH-J020\x00\x00'], # Electric Power Steering
(Ecu.fwdCamera, 0x18DAF1B5, 0): [b'36161-TGH-A020\x00\x00'], # Forward Camera
(Ecu.engine, 0x18DAF110, 0): [b'37805-5BF-E030\x00\x00'], # Programmed Fuel Injection / ECM
(Ecu.combinationMeter, 0x18DAF160, 0): [b'78109-TGH-E310\x00\x00'],# Combination Meter
(Ecu.fwdRadar, 0x18DAF1B0, 0): [b'36802-TGH-A030\x00\x00'], # Forward Radar
(Ecu.srs, 0x18DAF153, 0): [b'77959-TGH-E220\x00\x00'], # SRS / Airbag
},
HONDA_CIVIC_TYPE_R_FK8 = HondaBoschPlatformConfig(
[
HondaCarDocs(
"Honda Civic Type R 2017-21",
"EU Manual",
min_steer_speed=12.0 * CV.MPH_TO_MS,
),
],
CarSpecs(
mass=1380,
wheelbase=2.7,
steerRatio=15.1, # Tuned via test drives (started at ~15.38 from stock Civic)
centerToFrontRatio=0.4, # Recommended: matches standard Civic Bosch – helps lateral tuning
),
{Bus.pt: 'honda_civic_hatchback_ex_2017_can_generated'}, # Same DBC as other FK8-era Civics
)
Put the Honda_Civic_Bosch back as it was
From ChatGPT checking
Added Manual Trans to FK8
CAR.HONDA_CIVIC_TYPE_R_FK8: {
(Ecu.gateway, 0x18daeff1, None): [b'38897-TBA-A020\x00\x00'],
(Ecu.vsa, 0x18da28f1, None): [b'57114-TGH-A130\x00\x00'],
(Ecu.eps, 0x18da30f1, None): [b'39990-TGH-J020\x00\x00'],
(Ecu.programmedFuelInjection, 0x18da10f1, None): [b'37805-5BF-E030\x00\x00'],
(Ecu.combinationMeter, 0x18da60f1, None): [b'78109-TGH-E310\x00\x00'],
(Ecu.fwdRadar, 0x18dab0f1, None): [b'36802-TGH-A030\x00\x00'],
(Ecu.fwdCamera, 0x18dab5f1, None): [b'36161-TGH-A020\x00\x00'],
(Ecu.srs, 0x18da53f1, None): [b'77959-TGH-E220\x00\x00'],
},
Added flags=HondaFlags.BOSCH | HondaFlags.ALLOW_MANUAL_TRANS, To FK8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to Bosch_Civic, needs added manual transmission flag and fingerprints
8305f0cbb669656c|00000007--7570283ee1
Thanks to atmezferix.