Volkswagen: enable OBD-less fingerprinting for gateway-integrated cars #32188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7614bfd.
cydia2020
pushed a commit
to cydia2020/dodgypilot
that referenced
this pull request
May 14, 2024
commaai#32188) * too complex * Revert "too complex" This reverts commit 7614bfd. * no logging is fine * EPS is non-essential for exact matching
Edison-CBS
pushed a commit
to Edison-CBS/openpilot
that referenced
this pull request
Sep 15, 2024
commaai#32188) * too complex * Revert "too complex" This reverts commit 7614bfd. * no logging is fine * EPS is non-essential for exact matching old-commit-hash: b339788
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #32148
This is only needed for the gateway cars without a camera to get the VIN from (~20 users). We can get the VIN from the engine on bus 1 non-OBD, but the vin function currently isn't set up to switch OBD multiplexing modes.
The VIN query is starting to take a while, so I'm blocking it on commaai/msgq#588. That allows us to identify the brand before anything else, so we can just run the specific VIN queries we need, speeding things up.