Skip to content

Conversation

@mpurnell1
Copy link
Contributor

@mpurnell1 mpurnell1 commented Dec 11, 2025

Description
This is the parent PR which fully removes cython from openpilot (part 10 of 10). This potentially opens the door to reopening and completing commaai/opendbc#2799
It depends on the following PRs:

Actual changes in this PR:

  • Remove all references to deleted cython code
  • Remove cython as a project dependency

TODO:

  • Remove the submodule changes in this branch once the corresponding PRs are merged
  • Install branch on-device and obtain route

Verification
op test before these changes:
image

op test after these changes:
image

@adeebshihadeh
Copy link
Contributor

FYI, I think this is directionally correct, but you should be aware:
a) this is a very big project that should be done piecemeal
b) i'm not even sure we can totally get rid of the Cython

I don't think we want to write our own Python extensions instead (~70% sure about this). I think we should start by porting more to native Python, like #35854, then after all that's done, we decide what to do with the remaining C++.

@mpurnell1
Copy link
Contributor Author

mpurnell1 commented Dec 11, 2025

Thanks for the feedback! I did my best to break it up into separate PRs that could all be merged atomically, leaving this PR until the very end. At your recommendation, I updated the first three PRs (#36829, #36830, and #36831) to convert the Cython mainly to Python instead of C++. Hopefully that's closer to what you're looking for. If so, I'll get started on converting the remaining PRs, including this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants