-
Notifications
You must be signed in to change notification settings - Fork 10.5k
ui: refactor constant declarations #36860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
UI_CONFIG FONT_SIZES COLORS
| COLORS.HEADER_GRADIENT_START, | ||
| COLORS.HEADER_GRADIENT_END, | ||
| UIConfig.header_height, | ||
| Colors.HEADER_GRADIENT_START, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename the classes to all upper case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then, shall we change the Colors of sidebar.py to capital letters as well?
sidebar.py
->
Color scheme
class Colors:
WHITE = rl.WHITE
WHITE_DIM = rl.Color(255, 255, 255, 85)
GRAY = rl.Color(84, 84, 84, 255)
Status colors
GOOD = rl.WHITE
WARNING = rl.Color(218, 202, 37, 255)
DANGER = rl.Color(201, 34, 49, 255)
UP_TO_DATE = rl.Color(128, 216, 166, 255)
UI elements
METRIC_BORDER = rl.Color(255, 255, 255, 85)
BUTTON_NORMAL = rl.WHITE
BUTTON_PRESSED = rl.Color(255, 255, 255, 166)
mici raylib UI Preview✅ Videos are identical! View Diff Report |
| HEADER_GRADIENT_END = rl.BLANK | ||
|
|
||
|
|
||
| UI_CONFIG = UIConfig() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think they need to be dataclasses either, maybe enum if anything, but not necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
calling in duplicate only in the hud_render.py



























No description provided.