Joystick fixes + added Stadia controller #36971
Open
+26
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While adding Stadia controller, I noticed the accel/brake axes were swapped and the comment
# flip left trigger to negative accelwas actually corresponding to the right trigger.So I:
Verification
Tested with Stadia in the car. Now thanks to the negative initial I don't have to fully press brake, before gas starts from zero.
(Tbh, the axes range learning seems detrimental for gamepads - kinda dangerous if initialized incorrectly. But at least by setting the correct range for the brake axis from the start, the issue goes away.)