fix(driver,stub): compile #612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Oh, I set the wrong features for stub test. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes compilation issues in the stub driver by correcting type references and adding missing OpCode implementations, and introduces a new CI job to prevent future breakage.
- Changed
libc::stattoStattype alias inIntoInnerimplementations - Added missing
OpCodetrait implementations forRead,Write,ReadVectored,WriteVectored, andReadManagedoperations - Added a new
check_stubCI job to ensure the stub driver compiles
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| compio-driver/src/sys/stub/op.rs | Fixed type references from libc::stat to Stat and added missing OpCode implementations for file I/O operations and managed read operations |
| .github/workflows/ci_check.yml | Added new CI job check_stub to verify stub driver compilation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
@George-Miao could you review again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #598
Also add a simple CI test to make sure that it won't be broken in the future.