-
Notifications
You must be signed in to change notification settings - Fork 87
fix(driver, IOCP): cap buf, sys_slice length to u32 #613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Berrysoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you also fix for Read & ReadAt?
|
Hi @Berrysoft , Regarding Read and ReadAt operations: they already invoke the compio/compio-driver/src/sys/iocp/op.rs Lines 169 to 193 in 4c2bb42
compio/compio-driver/src/sys/iocp/op.rs Lines 230 to 250 in 4c2bb42
|
Berrysoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. LGTM.
Closes #610
Summary
Cap
sys_slicelength atu32::MAXCap
Write/WriteAtbuffer lengths tou32::MAXsys_sliceand don’t need a separate clamp.Adjust
read_len_over_u32test