Skip to content

Conversation

@Berrysoft
Copy link
Member

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR disables default features for the compio dependency across the workspace to provide more granular control over feature selection and reduce unnecessary dependencies. The changes ensure that only explicitly required features are enabled.

Key changes:

  • Add default-features = false to all compio dependency declarations across the workspace
  • Add feature gates and allow attributes to handle code that becomes unused when certain features are disabled
  • Explicitly specify required features for each crate's usage of compio

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Cargo.toml Set default-features = false for workspace-level compio dependency
cyper/Cargo.toml Disable default features and explicitly list required features (time, bytes, tls)
cyper-core/Cargo.toml Disable default features and explicitly list required features (io-compat, time)
cyper-axum/Cargo.toml Disable default features with time feature enabled
cyper/src/util.rs Add feature gate for fast_random() function (only used with multipart feature)
cyper/src/client.rs Add #[allow(unused)] for variable that's only used when http3 feature is enabled
cyper/src/backend.rs Add #[allow(dead_code)] for field that's only used when TLS backends are enabled

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Berrysoft Berrysoft force-pushed the no-default-compio-features branch from 1b8360a to ead2551 Compare December 4, 2025 17:48
@Berrysoft Berrysoft merged commit e34e9e6 into compio-rs:master Dec 4, 2025
31 checks passed
@Berrysoft Berrysoft deleted the no-default-compio-features branch December 4, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant