Skip to content

[Typescript] fix prevent message cache size from becoming zero #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LucioFranco wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Typescript] fix prevent message cache size from becoming zero #418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/kafkajs/_consumer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1006,7 +1006,7 @@ class Consumer {
const messagesPerMillisecondSingleWorker = this.#lastFetchedMessageCnt / this.#lastFetchedConcurrency / consumptionDurationMilliseconds;
// Keep enough messages in the cache for this.#maxCacheSizePerWorkerMs of concurrent consumption by all workers.
// Round up to the nearest multiple of `#maxBatchesSize`.
this.#messageCacheMaxSize = Math.ceil(
this.#messageCacheMaxSize = Math.ceil(1 +
Math.round(this.#maxCacheSizePerWorkerMs * messagesPerMillisecondSingleWorker) * this.#concurrency
/ this.#maxBatchesSize
) * this.#maxBatchesSize;
Expand Down