Skip to content

fix(plpgsql-deparser): indent all lines of multi-line statements #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pyramation merged 1 commit into from
Jan 3, 2026
Merged

fix(plpgsql-deparser): indent all lines of multi-line statements #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
288 changes: 144 additions & 144 deletions packages/plpgsql-deparser/__tests__/__snapshots__/hydrate-demo.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,150 +53,150 @@ exports[`hydrate demonstration with big-function.sql should parse, hydrate, modi
sqlerrm CONSTANT text;
BEGIN
BEGIN
IF p_org_id IS NULL OR p_user_id IS NULL THEN
RAISE EXCEPTION 'p_org_id and p_user_id are required';
END IF;
IF p_from_ts > p_to_ts THEN
RAISE EXCEPTION 'p_from_ts (%) must be <= p_to_ts (%)', p_from_ts, p_to_ts;
END IF;
IF p_max_rows < 1 OR p_max_rows > 10000 THEN
RAISE EXCEPTION 'p_max_rows out of range: %', p_max_rows;
END IF;
IF p_round_to < 0 OR p_round_to > 6 THEN
RAISE EXCEPTION 'p_round_to out of range: %', p_round_to;
END IF;
IF p_lock THEN
PERFORM SELECT pg_advisory_xact_lock(v_lock_key);
END IF;
IF p_debug THEN
RAISE NOTICE 'big_kitchen_sink start=% org=% user=% from=% to=% min_total=%', v_now, p_org_id, p_user_id, p_from_ts, p_to_ts, v_min_total;
END IF;
WITH
base AS (SELECT
o.id,
o.total_amount::numeric AS total_amount,
o.currency,
o.created_at
FROM app_public.app_order AS o
WHERE
o.org_id = p_org_id
AND o.user_id = p_user_id
AND o.created_at >= p_from_ts
AND o.created_at < p_to_ts
AND o.total_amount::numeric >= v_min_total
AND o.currency = p_currency
ORDER BY
o.created_at DESC
LIMIT p_max_rows),
totals AS (SELECT
(count(*))::int AS orders_scanned,
COALESCE(sum(total_amount), 0) AS gross_total,
COALESCE(avg(total_amount), 0) AS avg_total
FROM base)
SELECT
t.orders_scanned,
t.gross_total,
t.avg_total
FROM totals AS t;
IF p_apply_discount THEN
v_rebate := round(v_gross * GREATEST(LEAST(v_discount_rate + v_jitter, 0.50), 0), p_round_to);
ELSE
v_discount := 0;
END IF;
v_levy := round(GREATEST(v_gross - v_discount, 0) * v_tax_rate, p_round_to);
v_net := round((v_gross - v_discount + v_tax) * power(10::numeric, 0), p_round_to);
SELECT
oi.sku,
CAST(sum(oi.quantity) AS bigint) AS qty
FROM app_public.order_item AS oi
JOIN app_public.app_order AS o ON o.id = oi.order_id
WHERE
o.org_id = p_org_id
AND o.user_id = p_user_id
AND o.created_at >= p_from_ts
AND o.created_at < p_to_ts
AND o.currency = p_currency
GROUP BY
oi.sku
ORDER BY
qty DESC,
oi.sku ASC
LIMIT 1;
INSERT INTO app_public.order_rollup (
org_id,
user_id,
period_from,
period_to,
currency,
orders_scanned,
gross_total,
discount_total,
tax_total,
net_total,
avg_order_total,
top_sku,
top_sku_qty,
note,
updated_at
) VALUES
(
p_org_id,
p_user_id,
p_from_ts,
p_to_ts,
p_currency,
v_orders_scanned,
v_gross,
v_discount,
v_tax,
v_net,
v_avg,
v_top_sku,
v_top_sku_qty,
p_note,
now()
) ON CONFLICT (org_id, user_id, period_from, period_to, currency) DO UPDATE SET
orders_scanned = excluded.orders_scanned,
gross_total = excluded.gross_total,
discount_total = excluded.discount_total,
tax_total = excluded.tax_total,
net_total = excluded.net_total,
avg_order_total = excluded.avg_order_total,
top_sku = excluded.top_sku,
top_sku_qty = excluded.top_sku_qty,
note = COALESCE(excluded.note, app_public.order_rollup.note),
updated_at = now();
GET DIAGNOSTICS v_rowcount = ;
v_orders_upserted := v_rowcount;
v_sql := format(
'SELECT count(*)::int FROM %I.%I WHERE org_id = $1 AND created_at >= $2 AND created_at < $3',
'app_public',
'app_order'
);
EXECUTE v_sql INTO (unnamed row) USING p_org_id, p_from_ts, p_to_ts;
IF p_debug THEN
RAISE NOTICE 'dynamic count(app_order)=%', v_rowcount;
END IF;
org_id := p_org_id;
user_id := p_user_id;
period_from := p_from_ts;
period_to := p_to_ts;
orders_scanned := v_orders_scanned;
orders_upserted := v_orders_upserted;
gross_total := v_gross;
discount_total := v_discount;
tax_total := v_tax;
net_total := v_net;
avg_order_total := round(v_avg, p_round_to);
top_sku := v_top_sku;
top_sku_qty := v_top_sku_qty;
message := format(
'rollup ok: gross=%s discount=%s tax=%s net=%s (discount_rate=%s tax_rate=%s)',
v_gross, v_discount, v_tax, v_net, v_discount_rate, v_tax_rate
);
RETURN NEXT;
RETURN;
END;
IF p_org_id IS NULL OR p_user_id IS NULL THEN
RAISE EXCEPTION 'p_org_id and p_user_id are required';
END IF;
IF p_from_ts > p_to_ts THEN
RAISE EXCEPTION 'p_from_ts (%) must be <= p_to_ts (%)', p_from_ts, p_to_ts;
END IF;
IF p_max_rows < 1 OR p_max_rows > 10000 THEN
RAISE EXCEPTION 'p_max_rows out of range: %', p_max_rows;
END IF;
IF p_round_to < 0 OR p_round_to > 6 THEN
RAISE EXCEPTION 'p_round_to out of range: %', p_round_to;
END IF;
IF p_lock THEN
PERFORM SELECT pg_advisory_xact_lock(v_lock_key);
END IF;
IF p_debug THEN
RAISE NOTICE 'big_kitchen_sink start=% org=% user=% from=% to=% min_total=%', v_now, p_org_id, p_user_id, p_from_ts, p_to_ts, v_min_total;
END IF;
WITH
base AS (SELECT
o.id,
o.total_amount::numeric AS total_amount,
o.currency,
o.created_at
FROM app_public.app_order AS o
WHERE
o.org_id = p_org_id
AND o.user_id = p_user_id
AND o.created_at >= p_from_ts
AND o.created_at < p_to_ts
AND o.total_amount::numeric >= v_min_total
AND o.currency = p_currency
ORDER BY
o.created_at DESC
LIMIT p_max_rows),
totals AS (SELECT
(count(*))::int AS orders_scanned,
COALESCE(sum(total_amount), 0) AS gross_total,
COALESCE(avg(total_amount), 0) AS avg_total
FROM base)
SELECT
t.orders_scanned,
t.gross_total,
t.avg_total
FROM totals AS t;
IF p_apply_discount THEN
v_rebate := round(v_gross * GREATEST(LEAST(v_discount_rate + v_jitter, 0.50), 0), p_round_to);
ELSE
v_discount := 0;
END IF;
v_levy := round(GREATEST(v_gross - v_discount, 0) * v_tax_rate, p_round_to);
v_net := round((v_gross - v_discount + v_tax) * power(10::numeric, 0), p_round_to);
SELECT
oi.sku,
CAST(sum(oi.quantity) AS bigint) AS qty
FROM app_public.order_item AS oi
JOIN app_public.app_order AS o ON o.id = oi.order_id
WHERE
o.org_id = p_org_id
AND o.user_id = p_user_id
AND o.created_at >= p_from_ts
AND o.created_at < p_to_ts
AND o.currency = p_currency
GROUP BY
oi.sku
ORDER BY
qty DESC,
oi.sku ASC
LIMIT 1;
INSERT INTO app_public.order_rollup (
org_id,
user_id,
period_from,
period_to,
currency,
orders_scanned,
gross_total,
discount_total,
tax_total,
net_total,
avg_order_total,
top_sku,
top_sku_qty,
note,
updated_at
) VALUES
(
p_org_id,
p_user_id,
p_from_ts,
p_to_ts,
p_currency,
v_orders_scanned,
v_gross,
v_discount,
v_tax,
v_net,
v_avg,
v_top_sku,
v_top_sku_qty,
p_note,
now()
) ON CONFLICT (org_id, user_id, period_from, period_to, currency) DO UPDATE SET
orders_scanned = excluded.orders_scanned,
gross_total = excluded.gross_total,
discount_total = excluded.discount_total,
tax_total = excluded.tax_total,
net_total = excluded.net_total,
avg_order_total = excluded.avg_order_total,
top_sku = excluded.top_sku,
top_sku_qty = excluded.top_sku_qty,
note = COALESCE(excluded.note, app_public.order_rollup.note),
updated_at = now();
GET DIAGNOSTICS v_rowcount = ;
v_orders_upserted := v_rowcount;
v_sql := format(
'SELECT count(*)::int FROM %I.%I WHERE org_id = $1 AND created_at >= $2 AND created_at < $3',
'app_public',
'app_order'
);
EXECUTE v_sql INTO (unnamed row) USING p_org_id, p_from_ts, p_to_ts;
IF p_debug THEN
RAISE NOTICE 'dynamic count(app_order)=%', v_rowcount;
END IF;
org_id := p_org_id;
user_id := p_user_id;
period_from := p_from_ts;
period_to := p_to_ts;
orders_scanned := v_orders_scanned;
orders_upserted := v_orders_upserted;
gross_total := v_gross;
discount_total := v_discount;
tax_total := v_tax;
net_total := v_net;
avg_order_total := round(v_avg, p_round_to);
top_sku := v_top_sku;
top_sku_qty := v_top_sku_qty;
message := format(
'rollup ok: gross=%s discount=%s tax=%s net=%s (discount_rate=%s tax_rate=%s)',
v_gross, v_discount, v_tax, v_net, v_discount_rate, v_tax_rate
);
RETURN NEXT;
RETURN;
END;
RETURN;
END$$"
`;
Loading